Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev nms #6817

Merged
merged 21 commits into from
Nov 20, 2021
Merged

Dev nms #6817

merged 21 commits into from
Nov 20, 2021

Conversation

simonJJJ
Copy link
Contributor

No description provided.

@simonJJJ simonJJJ requested a review from Ldpe2G November 19, 2021 05:41
MARD1NO
MARD1NO reviewed Nov 19, 2021
View reviewed changes
oneflow/user/kernels/nms_kernel.cu
}

template<typename T>
__host__ __device__ __forceinline__ T IoU(T const* const a, T const* const b) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是哪种格式的IOU？

x y x y 还是 x y w h？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xyxy

python/oneflow/nn/modules/nms.py Show resolved Hide resolved
python/oneflow/nn/modules/nms.py Show resolved Hide resolved
@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: GeForce GTX 1080 

OneFlow resnet50 time: 137.4ms (= 13737.4ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 141.5ms (= 14150.3ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.03 (= 141.5ms / 137.4ms)

OneFlow resnet50 time: 80.7ms (= 8073.6ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 86.2ms (= 8620.7ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.07 (= 86.2ms / 80.7ms)

OneFlow resnet50 time: 54.9ms (= 10973.1ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 59.7ms (= 11930.8ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.09 (= 59.7ms / 54.9ms)

OneFlow resnet50 time: 45.4ms (= 9074.7ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 49.3ms (= 9864.4ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.09 (= 49.3ms / 45.4ms)

OneFlow resnet50 time: 38.0ms (= 7597.7ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 41.4ms (= 8283.7ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 1.09 (= 41.4ms / 38.0ms)

OneFlow resnet50 time: 158.2ms (= 15818.8ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 161.1ms (= 16110.1ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.02 (= 161.1ms / 158.2ms)

OneFlow resnet50 time: 100.6ms (= 10061.8ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 104.3ms (= 10429.1ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.04 (= 104.3ms / 100.6ms)

OneFlow resnet50 time: 75.3ms (= 15069.9ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 75.8ms (= 15169.0ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.01 (= 75.8ms / 75.3ms)

OneFlow resnet50 time: 72.5ms (= 14507.8ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 68.9ms (= 13775.8ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 0.95 (= 68.9ms / 72.5ms)

OneFlow resnet50 time: 70.0ms (= 14009.3ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 61.5ms (= 12301.5ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 0.88 (= 61.5ms / 70.0ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review November 19, 2021 10:44
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot November 19, 2021 10:55
@oneflow-ci-bot oneflow-ci-bot self-requested a review November 19, 2021 15:29
@github-actions
Copy link
Contributor

CI failed, removing label automerge

@oneflow-ci-bot oneflow-ci-bot removed their request for review November 19, 2021 19:05
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot November 20, 2021 07:28
@github-actions
Copy link
Contributor

CI failed, removing label automerge

@oneflow-ci-bot oneflow-ci-bot removed their request for review November 20, 2021 07:59
@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: GeForce GTX 1080 

OneFlow resnet50 time: 138.4ms (= 13839.1ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 140.5ms (= 14053.9ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.02 (= 140.5ms / 138.4ms)

OneFlow resnet50 time: 79.6ms (= 7962.1ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 86.2ms (= 8618.8ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.08 (= 86.2ms / 79.6ms)

OneFlow resnet50 time: 53.3ms (= 10655.1ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 58.3ms (= 11656.4ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.09 (= 58.3ms / 53.3ms)

OneFlow resnet50 time: 40.1ms (= 8024.5ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 47.7ms (= 9540.5ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.19 (= 47.7ms / 40.1ms)

OneFlow resnet50 time: 44.3ms (= 8868.7ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 43.6ms (= 8711.8ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 0.98 (= 43.6ms / 44.3ms)

OneFlow resnet50 time: 158.6ms (= 15856.1ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 164.5ms (= 16450.3ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.04 (= 164.5ms / 158.6ms)

OneFlow resnet50 time: 99.6ms (= 9964.6ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 104.5ms (= 10445.1ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.05 (= 104.5ms / 99.6ms)

OneFlow resnet50 time: 75.6ms (= 15122.0ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 78.3ms (= 15650.5ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.03 (= 78.3ms / 75.6ms)

OneFlow resnet50 time: 74.7ms (= 14937.1ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 68.2ms (= 13634.4ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 0.91 (= 68.2ms / 74.7ms)

OneFlow resnet50 time: 66.1ms (= 13226.3ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 63.4ms (= 12671.7ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 0.96 (= 63.4ms / 66.1ms)

@github-actions
Copy link
Contributor

CI failed, removing label automerge

@oneflow-ci-bot oneflow-ci-bot removed their request for review November 20, 2021 09:31
@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: GeForce GTX 1080 

OneFlow resnet50 time: 137.1ms (= 13713.0ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 140.4ms (= 14043.7ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.02 (= 140.4ms / 137.1ms)

OneFlow resnet50 time: 78.8ms (= 7883.2ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 85.7ms (= 8571.0ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.09 (= 85.7ms / 78.8ms)

OneFlow resnet50 time: 52.0ms (= 10392.8ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 59.8ms (= 11953.2ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.15 (= 59.8ms / 52.0ms)

OneFlow resnet50 time: 42.5ms (= 8493.6ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 46.5ms (= 9308.0ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.10 (= 46.5ms / 42.5ms)

OneFlow resnet50 time: 41.5ms (= 8305.8ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 41.1ms (= 8224.7ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 0.99 (= 41.1ms / 41.5ms)

OneFlow resnet50 time: 157.1ms (= 15711.2ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 164.0ms (= 16402.9ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.04 (= 164.0ms / 157.1ms)

OneFlow resnet50 time: 101.1ms (= 10105.1ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 104.5ms (= 10449.8ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.03 (= 104.5ms / 101.1ms)

OneFlow resnet50 time: 74.1ms (= 14819.1ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 76.4ms (= 15276.6ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.03 (= 76.4ms / 74.1ms)

OneFlow resnet50 time: 70.3ms (= 14056.8ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 70.0ms (= 13999.5ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.00 (= 70.0ms / 70.3ms)

OneFlow resnet50 time: 70.5ms (= 14105.4ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 62.4ms (= 12484.6ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 0.89 (= 62.4ms / 70.5ms)

@oneflow-ci-bot oneflow-ci-bot merged commit 62f96f5 into master Nov 20, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the dev_nms branch November 20, 2021 11:58
jackalcooper added a commit that referenced this pull request Dec 1, 2021
@jackalcooper @ouyangyu
@oneflow-ci-bot @daquexian @guo-ran @liujuncheng @lixiang007666 @dssgsra @simonJJJ @lixinqi @Ldpe2G @MARD1NO @liufengwei0103 @Flowingsun007 @strint @clackhan @dangkai4u @BBuf @chengtbf @hjchen2 @VertexC @HENGRui6 @doombeaker @tingkuanpei @grybd @Garfieldgzhh @wyg1997 @PragmaTwice @luqiang-guo
Refactor jit interpreter with updated ods (#6899)
f14b1b1 
* Rename class OneflowVM to VirtualMachine (#6753)

* Rename class OneflowVM to VirtualMachine

* refine

* refine

* refine

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* upgrade cub to 1.11.0 for NVIDIA/cub#170 (#6795)

Signed-off-by: daquexian <daquexian566@gmail.com>

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* lazy create cuda_stream  (#6806)

* lazy create cuda_stream in CudaCopyD2HDeviceCtx CudaStreamHandleDeviceCtx

* refine

* Remove KernelContext::stream_ctx() (#6805)

* Remove KernelContext::stream_ctx()

* fix GetCudaAlignedSize

* refine

* Remove StreamContextAdapter

* refine include

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* add tensor method docstr (#6800)

* add tensor method docstr

* add tensor method docstr

* add tensor method docstr

* add tensor method docstr

* add tensor method docstr

* add tensor method docstr

* add tensor method docstr

* fix ci related bug

* set common compiler flags in oneflow_add_library(...), enable it for CUDA (#6813)

* apply treating warnings as errors in oneflow_add_library(...), enable it to CUDA

Signed-off-by: daquexian <daquexian566@gmail.com>

* support target_try_compile_options on clang cuda

Signed-off-by: daquexian <daquexian566@gmail.com>

* reorder oneflow_add_library

Signed-off-by: daquexian <daquexian566@gmail.com>

* add cuda-61-clang.cmake and cuda-75-clang.cmake

Signed-off-by: daquexian <daquexian566@gmail.com>

* move oneflow_add_xxx after set_compile_options_to_oneflow_target

Signed-off-by: daquexian <daquexian566@gmail.com>

* reformat

Signed-off-by: daquexian <daquexian566@gmail.com>

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Use ep::Stream instead of DeviceCtx (#6825)

* remove redundant code (#6807)

* Prevent CI failure when cublas alloc fail (#6826)

* Dev nms (#6817)

* fix typo

* dev nms

* fix

* fix

* fix format

* skip distribute test

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Refactor vm consuming (#6748)

* refactor PhyInstrOperand::ForEachXXXMirroredObject

* remove ForEachXXXMirroredObject4XXXPhyInstrOperand

* reduce for-loops for InstructionList

* reduce for-loops on InstructionMsgList

* refactor MakeInstructions

* refactor PhyInstrOperand::ForEachXXXMirroredObject

* 1) refactor ConnectInstruction to TryConnectInstruction; 2) refactor BackInserter to SetInserter

* create RwMutextObjectAccess/InstructionEdge from intrusive::ObjectPool

* refactor profiler range name

* fix barrier instruction comment typos

* fix compiler complaints

* Update oneflow/core/intrusive/object_pool.h

Co-authored-by: daquexian <daquexian566@gmail.com>

* fix static analysis complaints

Co-authored-by: daquexian <daquexian566@gmail.com>
Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Add init method docstr modify int to int32 (#6828)

* Add nn.init method docstr, and modify np.int

* Add nn.init method docstr, and modify np.int

* Check  whether the expand_shape parameter is legal (#6812)

* check parameters

* simplify logic

* fix ci error

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* refactor local call opkernel instruction (#6733)

* remove CheckOutputBlobObjectsMemCase

* move calling of ChooseOpKernel from scheduler thread to main thread.

* address pr comments

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* one_hot primitive interface (#6796)

* one_hot primitive interface

* refine

* refine

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* revert DependenceVector to std::vector (#6835)

* fix indexed slice for adam max_x (#6824)

Co-authored-by: ZZK <42901638+MARD1NO@users.noreply.github.com>
Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* set str option (#6832)

* set str option

* refine

* refine

* fix

* refine

* fix

* fix

* refine

* refine

* refine

* fix

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Empty op support float16 (#6847)

* support fp16

* add float16 test case

* add graph cudnn conv alg config (#6799)

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Dev vm view instruction (#6815)

* shallow copy

* try reset blob data

* refine

* debug

* raw implementation

* refine

* refine

* to_contiguous op

* reine

* refine

* refine

* set_last_used_device

* refine

* raw implementation

* debug

* replace TryResetBlobData with SyncAccessBlobByCallback

* tensor_view_instruction

* refine

* tensor_view_operand

* remove tensor_view_phy_instr_operand

* refine

* refine

* refine

* restruct

* refine

* refine

* refine

* refine

* Remove deafult l2 and use bias add in lazy mode (#6844)

* remove_deafult_l2_and_use_bias_add_in_lazy_mode

* minor fix

* minor fix

* undo bais add

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Add arccos op and docstr (#6841)

* Add arccos op and docstr

* fix docstr format

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* add some fused kernels (#6635)

* fix errors, op with dropout successes, but op without dropout has error

* fix errors, success

* fix typo error

* test dropout

* add comments

* fix typos

* change format

* reformat file

* fix error

* change format

* remove useless head file

* fix errors

* fix errors

* reformat

* fix errors

* reformat

* fix errors

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>
Co-authored-by: ZZK <42901638+MARD1NO@users.noreply.github.com>

* Add CUDA arch 52 back and compile it in CI (#6802)

* Add CUDA arch 53 back and compile it in CI

* fix cuda

* fix

* don't build 52 by default

* rm comment

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* [EP] Add ep::Device/ep::Event (#6851)

* [EP] Add ep::Device/ep::Event

* Refine ActiveDeviceContext

* fix

* refine include

* fix tidy error

* fix cudaEventRecord

* fix test

* refine

* Fix FuseBN eval error (#6836)

* fix arange bug

* fix fuse bn

* Remove redundant saved_tensor

* fix bug

* add more test case

* add more random test case

* add fuse functor when track_stats=false

* fix backward errror when track_stats=false

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Remove KernelXxxContext::device_ctx()/device_ctx() (#6862)

* pool code refine (#6853)

* pool code refine

* refine

* format

* fix static analysis error

* fix max_pool_2d_grad name

* prefix tf is used to pool functor name

* fix

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Add cpu group conv impl (#6823)

* add cpu group conv kernel, test success

* add group conv cpu backward kernel

* rename

* update test case

* fix comment

* fix comments

* fix comment

* optimize again and fix ci eroor

* fix error

* fix ci error

* fix ci_tidy error

* fix ci error

* revert code

* fix bug

* delete useless file

* delete useless file

* fix ci error

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Add nsys profile host thread name (#6865)

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Rename DeviceType::kGPU to DeviceType::kCUDA (#6863)

* Rename DeviceType::kGPU to DeviceType::kCUDA

* fix

* fix typo

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Check modify op module (#6860)

* Add arccos op and docstr

* Check and modify Op module

* delete register_tensor_op

* Fix random ops (#6868)

Co-authored-by: Bowen Chen <bob2420083992@gmail.com>
Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* fix docstr problem (#6554)

* fix docstr problem

* fix

* Update random.py

Co-authored-by: Yao Chi <later@usopp.net>

* fix retinanet (#6870)

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Optimize LayerNorm Forward (#6842)

* layer_norm forward

* test case

* rm useless

* int count to T count

* fix

* fix T mask to int mask, refine code

* refine

* refine

* test case

* format

* fix

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Refactor last used device (#6852)

* move last_used_device

* refine

* refine

* fix pipeline delay ctrl edge between src subset tick and output (#6881)

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Support OpenVINO in xrt (#6709)

* Support openvino in xrt

* OpenVINO: add graph input and weight in op

* OpenVINO: support more op

* update follow review

* update follow review

* update follow review

* Add doc for graph_config.py

* update follow review

* update follow review

* modify after review

* format

* add xrt in check_src.py

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Dev optimize std vector (#6630)

* use reserve

* use emplace_back

* refine

* remove useless codes (#6859)

* remove useless codes

* fix index_select

* fix expand error

* fix expand error

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* add alpha parameter in add_op (#6867)

* add alpha parameter in add_op

* format

* refine

* refine

* refine

* fix bug about dtype caused by alpha

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* add fallback to cpu builder (#6582)

* add fallback to cpu slice boxing

* fix

* fix

* merge master

* format

* fix

* modify graph.py (#6884)

Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org>

* fix eye op attr name error (#6873)

* fix eye op attr name error

* refine

* refine

* fix

* delete useless attr

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* add inplace mul (#6861)

* init commit for inplace mul

* fix issue, format code

* add tests and fix issues

* format code

* delete redundant code

* Update oneflow/core/functional/impl/binary_functor.cpp

Co-authored-by: Yinggang Wang <wyg19970408@gmail.com>

* refine

* fix unit test

* fix bug

* refine

* fix unittests

* add boardcast test

* refine

* refine

* fix ci issue

Co-authored-by: Yinggang Wang <wyg19970408@gmail.com>

* Dev roialign (#6879)

* dev roialign

* testcase

* fux

* fix

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Pick Variant from Standalone Maybe (#6856)

* refactor maybe: add variant

* maybe: add optional and tests

* maybe: add hash for optional & variant; support NullOpt for both optional & variant

* maybe: more notes

* maybe: binary search impl for Variant::Visit

* maybe: add more relational operator to optional & variant

* maybe: add nonstd::string_view

* maybe: fix construct of optional & variant

* maybe: support comparision for optional & variant

* maybe: add monadic operations for optional

* maybe: add error traits

* maybe: add JUST and Maybe

* maybe: remove useless comment

* maybe: add more test

* maybe: customizable JUST

* maybe: add Map and Bind (AndThen) to Maybe

* maybe: re-design JustConfig

* maybe: rename xxxT to xxxS

* maybe: fix method names

* maybe: add maybe to cmake

* maybe: fix error traits

* maybe: rename fields & add aggregate type checking

* maybe: move string_view to new file

* maybe: rename fields for optional and error

* maybe: new Value (no index checking, protected method) and Get (has check, public method)

* maybe: remove DefaultArgument

* Pick Variant from Standalone Maybe

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Limit CI run speed test on one machine (#6891)

* Run speed test on one machine

* fix

* Add oneDNN (#6767)

* add onednn cmake

* add onednn stream engine

* Successfully implement addn

* add int64 double

* optimization voctor

* fix

* fix  merge master error

* fix merge  master

* fix merge error

* Add BUILD_ONEDNN cmake flags

* fix format

* fix  onednn datatype

* optmizer  onedn  type

* modified for(n) => for(i)

* modified ci

* modified oneDNN.cmake

* fix  clang 10 error

* rename BUILD_ONEDNN

* Delete oneDNN installation path by mistake

* fix ci error, c++: error: third_party_install/onednn/lib/libdnnl.a: No such file or directory

* include(GNUInstallDirs)

* print  ci error

* reformat

* Only the first parameter can be operated inplace

* format

* fix inlcude onednn, add clang 11 support  refernce

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Rework op import with new ods (#6883)

* add naive impl

* refine

* refine

* refine

* add naive gen td

* refine

* refine

* fix

* refine

* refine

* refine

* sort alphabetically

* support optional

* support Variadic

* refine

* refine

* add conv

* add input output order

* add todo

* add todo

* refine

* refine

* refine

* refine

* naive bn order interface

* fix includes

* refine

* refine

* refine

* refine

* group ops

* refine order

* add math

* refine

* refine

* refine

* refine

* refine

* refine

* add quantization ops

* refine

* refine

* add detection

* fix

* refien

* add new .td generated

* refine

* refine

* refine

* refine

* refine

* refine

* refine

* refine

* Use generated ods in mlir (#6857)

* refine

* check in changes

* refine

* move pattern to another file

* compile grouped op

* refine

* add todo

* fix

* add GetUserOpDef in wrapper

* check in files

* refine

* refine

* fix

* refine

* refine

* refine

* refine

* refine

* refine

* refine tablegen

* refine

* fix

* refine

* refine

* refine

* refine

* refine

* refine

* refine

* refien

* refine

* refine

* refine

* refine

* fix

* refine

* rm log

* refine

* refine

* make ctrl edge type safe

* refine

* refine

* refine

* rm legacy code

* refine

* refien

* refine

* dirty trick addn2 without variadic deduction

* fix jit op

* refine

* extract GetOutputLbn

* refine

* fix for single seg

* refine

* rm todo

* update .mlir file

* refine

* add todo

* refine

* refine

* refine

* refine

* refine

* add log

* refine

* refine

* make op_type_name type safe

* refine

* refine

* refine

* delete trainable

* add IsOpConfCompatible

* add IsImportCompatible

* refine

* refien

* mv ir_pass.cpp out of core

* refine

* refine

* refine

* refine

* refine

* refine

* gen new ods from master

* refine

* refine

* update for tf pool ops

* refine

* refine

* refine

* refine APIs

* refine order

* rm

* rm output_lbn_segment_keys

* output_lbn_segment_sizes

* rm output_lbns

* refine

* refine

* refine

* refine

* fmt

* use less cores to prevent OOM in CI

* refine

* refine

Co-authored-by: BBuf <1182563586@qq.com>
Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* add cudnn.h (#6886)

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>
Co-authored-by: Shenghang Tsai <jackalcooper@gmail.com>

* refine

* refactor jit interpreter with updated ODS

* refine

Co-authored-by: Yu OuYang <xuanjiuye@gmail.com>
Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>
Co-authored-by: daquexian <daquexian566@gmail.com>
Co-authored-by: guo ran <360112263@qq.com>
Co-authored-by: Juncheng <liujuncheng1022@gmail.com>
Co-authored-by: Li Xiang <54010254+lixiang007666@users.noreply.github.com>
Co-authored-by: dssgsra <dssgsra@gmail.com>
Co-authored-by: Shijie <821898965@qq.com>
Co-authored-by: Li Xinqi <lixinqi2010@gmail.com>
Co-authored-by: Liang Depeng <liangdepeng@gmail.com>
Co-authored-by: ZZK <42901638+MARD1NO@users.noreply.github.com>
Co-authored-by: liufengwei0103 <2472937968@qq.com>
Co-authored-by: Luyang <flowingsun007@163.com>
Co-authored-by: Xiaoyu Xu <xiaoyulink@gmail.com>
Co-authored-by: binbinHan <han_binbin@163.com>
Co-authored-by: DangKai <dangkai4u@outlook.com>
Co-authored-by: Xiaoyu Zhang <35585791+BBuf@users.noreply.github.com>
Co-authored-by: cheng cheng <472491134@qq.com>
Co-authored-by: Houjiang Chen <chenhoujiangcug@gmail.com>
Co-authored-by: Bowen Chen <bob2420083992@gmail.com>
Co-authored-by: Derek Zhang <85550485+HENGRui6@users.noreply.github.com>
Co-authored-by: Yao Chi <later@usopp.net>
Co-authored-by: tingkuanpei <50049308+tingkuanpei@users.noreply.github.com>
Co-authored-by: grybd <52237830+grybd@users.noreply.github.com>
Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org>
Co-authored-by: Zhanghuihong Guan <31779698+Garfieldgzhh@users.noreply.github.com>
Co-authored-by: Yinggang Wang <wyg19970408@gmail.com>
Co-authored-by: Twice <i@twice.moe>
Co-authored-by: luqiang guo <702572275@qq.com>
Co-authored-by: BBuf <1182563586@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MARD1NO MARD1NO MARD1NO left review comments

@Ldpe2G Ldpe2G Ldpe2G approved these changes

@daquexian daquexian Awaiting requested review from daquexian

@guo-ran guo-ran Awaiting requested review from guo-ran

@hjchen2 hjchen2 Awaiting requested review from hjchen2 hjchen2 is a code owner

@jackalcooper jackalcooper Awaiting requested review from jackalcooper

@liujuncheng liujuncheng Awaiting requested review from liujuncheng liujuncheng is a code owner

@oneflow-ci-bot oneflow-ci-bot Awaiting requested review from oneflow-ci-bot

Assignees
No one assigned
Labels
automerge eager enhancement need-clean-ccache op
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simonJJJ @Ldpe2G @MARD1NO @oneflow-ci-bot