Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty debug str of hob primitive #7245

Merged
merged 10 commits into from
Jan 14, 2022
Merged

fix empty debug str of hob primitive #7245

Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3996e77
fix empty debug str of hob primitive
daquexian Jan 12, 2022
156eac2
fix 'OF_PP_STRINGIZE(op)'
daquexian Jan 12, 2022
9653cfe
Merge branch 'master' into fix_hob_empty_debug_str
oneflow-ci-bot Jan 13, 2022
62f5eac
Merge branch 'master' into fix_hob_empty_debug_str
oneflow-ci-bot Jan 13, 2022
c495827
Merge branch 'master' into fix_hob_empty_debug_str
oneflow-ci-bot Jan 13, 2022
e1992bd
Merge branch 'master' into fix_hob_empty_debug_str
oneflow-ci-bot Jan 13, 2022
7e56c0f
Merge branch 'master' into fix_hob_empty_debug_str
oneflow-ci-bot Jan 13, 2022
468ef00
Merge branch 'master' into fix_hob_empty_debug_str
MARD1NO Jan 14, 2022
244d209
Merge branch 'master' into fix_hob_empty_debug_str
oneflow-ci-bot Jan 14, 2022
bcbb23b
Merge branch 'master' into fix_hob_empty_debug_str
oneflow-ci-bot Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions oneflow/core/common/high_order_bool.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ struct Expr : public BaseExpr<Context, ValueT> {

template<typename Context, typename ValueT>
struct Literal final : public Expr<Context, ValueT, Literal<Context, ValueT>> {
Literal(const ValueT& val) : Literal("", val) {} // NOLINT
Literal(const ValueT& val) : Literal(ToString(val), val) {} // NOLINT
Literal(const std::string& debug_str, const ValueT& val) : val_(val), debug_str_(debug_str) {}
ALWAYS_INLINE scalar_or_const_ref_t<ValueT> get(const Context&) const override { return val_; }
std::string DebugStr(const Context&, bool display_result) const override { return debug_str_; }
Expand Down Expand Up @@ -169,7 +169,7 @@ DEFINE_BINARY_FUNCTOR(EqualOrLess, <=)
std::string l_str = lhs_.DebugStr(ctx, display_result); \
std::string r_str = rhs_.DebugStr(ctx, display_result); \
std::ostringstream string_stream; \
string_stream << "(" << l_str << " OF_PP_STRINGIZE(op) " << r_str << ")"; \
string_stream << "(" << l_str << " " << OF_PP_STRINGIZE(op) << " " << r_str << ")"; \
return string_stream.str(); \
}

Expand Down