Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eager global masked select #7492

Merged
merged 31 commits into from
Feb 21, 2022
Merged

eager global masked select #7492

merged 31 commits into from
Feb 21, 2022

Conversation

liufengwei0103
Copy link
Contributor

@liufengwei0103 liufengwei0103 commented Feb 14, 2022

@github-actions
Copy link
Contributor

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 14, 2022 11:57
@oneflow-ci-bot oneflow-ci-bot self-requested a review February 14, 2022 12:42
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 14, 2022 15:14
@github-actions
Copy link
Contributor

CI failed when running job: cuda-module-distributed. PR label automerge has been removed

@oneflow-ci-bot oneflow-ci-bot removed their request for review February 14, 2022 17:12
@github-actions
Copy link
Contributor

CI failed when running job: cuda-module-distributed-rank-1. PR label automerge has been removed

@liufengwei0103 liufengwei0103 requested review from oneflow-ci-bot and removed request for daquexian, jackalcooper and oneflow-ci-bot February 19, 2022 04:26
@oneflow-ci-bot oneflow-ci-bot removed their request for review February 19, 2022 07:05
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 21, 2022 03:00
@github-actions
Copy link
Contributor

CI failed when running job: cuda-module-distributed-rank-0. PR label automerge has been removed

@github-actions
Copy link
Contributor

CI failed when running job: cuda-module-distributed-rank-1. PR label automerge has been removed

@oneflow-ci-bot oneflow-ci-bot removed their request for review February 21, 2022 04:58
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

✔️ OneFlow resnet50 time: 128.7ms (= 12873.6ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 137.2ms (= 13715.4ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.07 (= 137.2ms / 128.7ms)

✔️ OneFlow resnet50 time: 78.4ms (= 7842.7ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 83.7ms (= 8369.8ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.07 (= 83.7ms / 78.4ms)

OneFlow resnet50 time: 52.9ms (= 10577.1ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 60.4ms (= 12071.9ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.14 (= 60.4ms / 52.9ms)

OneFlow resnet50 time: 41.0ms (= 8198.6ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 47.7ms (= 9535.0ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.16 (= 47.7ms / 41.0ms)

OneFlow resnet50 time: 38.2ms (= 7636.8ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 43.9ms (= 8786.4ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 1.15 (= 43.9ms / 38.2ms)

✔️ OneFlow resnet50 time: 142.7ms (= 14269.6ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 160.1ms (= 16009.6ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.12 (= 160.1ms / 142.7ms)

OneFlow resnet50 time: 90.0ms (= 9003.2ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 103.6ms (= 10358.7ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.15 (= 103.6ms / 90.0ms)

OneFlow resnet50 time: 62.4ms (= 12471.8ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 75.6ms (= 15117.0ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.21 (= 75.6ms / 62.4ms)

OneFlow resnet50 time: 53.2ms (= 10634.4ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 67.6ms (= 13525.6ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.27 (= 67.6ms / 53.2ms)

OneFlow resnet50 time: 47.6ms (= 9514.5ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 64.4ms (= 12887.2ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.35 (= 64.4ms / 47.6ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review February 21, 2022 07:09
@oneflow-ci-bot oneflow-ci-bot merged commit 9d9ba55 into master Feb 21, 2022
@oneflow-ci-bot oneflow-ci-bot deleted the eager_global_masked_select branch February 21, 2022 07:12
marigoold pushed a commit that referenced this pull request Mar 15, 2022
* eager global masked select

* refine

* fix

* refine

* refine error msg

* auto format by CI

* refine

* enhance case

* Reduce data size in test case

* Reduce data size in test case

* reduce meshgrid test case number

* refine

* refine

Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org>
Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants