Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flip consistent test bug #7496

Merged
merged 44 commits into from
Feb 22, 2022
Merged

Fix flip consistent test bug #7496

merged 44 commits into from
Feb 22, 2022

Conversation

BBuf
Copy link
Contributor

@BBuf BBuf commented Feb 14, 2022

解决:https://github.com/Oneflow-Inc/OneTeam/issues/1012#issuecomment-1038801402

python3 -m oneflow.distributed.launch --master_port=23452 --nproc_per_node=2 /home/zhangxiaoyu/oneflow/python/oneflow/test/modules/test_consistent_flip.py --verbose --failfast

图片

Copy link
Contributor

@wyushun wyushun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review done.

@github-actions
Copy link
Contributor

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

@BBuf BBuf requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 15, 2022 01:53
@BBuf BBuf requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 15, 2022 01:55
@github-actions
Copy link
Contributor

CI failed when running job: cpu-module. PR label automerge has been removed

@BBuf BBuf requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 15, 2022 02:54
@BBuf BBuf added the automerge label Feb 15, 2022
@github-actions
Copy link
Contributor

CI failed when running job: cuda-module. PR label automerge has been removed

@oneflow-ci-bot oneflow-ci-bot removed their request for review February 20, 2022 11:01
@hjchen2 hjchen2 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 21, 2022 07:53
@oneflow-ci-bot oneflow-ci-bot removed their request for review February 21, 2022 09:26
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 21, 2022 09:56
@oneflow-ci-bot oneflow-ci-bot self-requested a review February 21, 2022 14:47
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 21, 2022 17:57
@oneflow-ci-bot oneflow-ci-bot self-requested a review February 21, 2022 23:16
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

✔️ OneFlow resnet50 time: 128.5ms (= 12851.1ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 140.7ms (= 14069.9ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.09 (= 140.7ms / 128.5ms)

✔️ OneFlow resnet50 time: 78.5ms (= 7853.4ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 84.3ms (= 8427.1ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.07 (= 84.3ms / 78.5ms)

OneFlow resnet50 time: 52.4ms (= 10486.4ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 58.2ms (= 11633.7ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.11 (= 58.2ms / 52.4ms)

OneFlow resnet50 time: 44.1ms (= 8815.3ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 46.9ms (= 9385.9ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.06 (= 46.9ms / 44.1ms)

OneFlow resnet50 time: 39.2ms (= 7844.3ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 37.4ms (= 7487.6ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 0.95 (= 37.4ms / 39.2ms)

✔️ OneFlow resnet50 time: 140.9ms (= 14088.0ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 161.7ms (= 16173.9ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.15 (= 161.7ms / 140.9ms)

OneFlow resnet50 time: 89.5ms (= 8954.2ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 101.7ms (= 10167.7ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.14 (= 101.7ms / 89.5ms)

OneFlow resnet50 time: 61.2ms (= 12249.3ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 73.3ms (= 14656.1ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.20 (= 73.3ms / 61.2ms)

OneFlow resnet50 time: 53.7ms (= 10745.2ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 65.8ms (= 13152.1ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.22 (= 65.8ms / 53.7ms)

OneFlow resnet50 time: 48.2ms (= 9641.2ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 64.9ms (= 12981.2ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.35 (= 64.9ms / 48.2ms)

@hjchen2 hjchen2 merged commit 897e5fc into master Feb 22, 2022
@hjchen2 hjchen2 deleted the fix_flip_consistent_test_bug branch February 22, 2022 02:33
marigoold pushed a commit that referenced this pull request Mar 15, 2022
* fix flip op consistent test bug

* format

* delete useless code

* fix comment

* auto format by CI

* fix ci error

* check nd_sbp boxing axis_expandable

* remove deprecated unittests in framework/placement_sbp_util_test.cpp

Co-authored-by: binbinHan <han_binbin@163.com>
Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org>
Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>
Co-authored-by: lixinqi <lixinqi0703106@163.com>
Co-authored-by: hjchen2 <chenhoujiangcug@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants