Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix maximum minimum backward bug #7519

Merged
merged 36 commits into from
Feb 25, 2022
Merged

fix maximum minimum backward bug #7519

merged 36 commits into from
Feb 25, 2022

Conversation

liufengwei0103
Copy link
Contributor

@liufengwei0103 liufengwei0103 commented Feb 17, 2022

at::where(self == other, grad / 2, grad).masked_fill_(self > other, 0) torch做法
fix https://github.com/Oneflow-Inc/OneTeam/issues/1048
fix https://github.com/Oneflow-Inc/OneTeam/issues/1051

@github-actions
Copy link
Contributor

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

@liufengwei0103 liufengwei0103 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 17, 2022 07:40

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 17, 2022 07:52

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 17, 2022 10:13

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 17, 2022 16:58

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 17, 2022 21:13

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@oneflow-ci-bot oneflow-ci-bot self-requested a review February 18, 2022 02:35
@oneflow-ci-bot oneflow-ci-bot self-requested a review February 24, 2022 14:11

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 24, 2022 15:39
@github-actions
Copy link
Contributor

CI failed when running job: cuda-module-distributed-rank-0. PR label automerge has been removed

@oneflow-ci-bot oneflow-ci-bot removed their request for review February 24, 2022 16:49
@liufengwei0103 liufengwei0103 requested review from oneflow-ci-bot and removed request for daquexian and jackalcooper February 25, 2022 02:52

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@liufengwei0103 liufengwei0103 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 25, 2022 02:53
@oneflow-ci-bot oneflow-ci-bot removed their request for review February 25, 2022 04:19

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 25, 2022 07:30

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 25, 2022 09:21

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 25, 2022 11:12
@hjchen2 hjchen2 merged commit cac552a into master Feb 25, 2022
@hjchen2 hjchen2 deleted the fix_maximum_minimum_bug branch February 25, 2022 13:42
marigoold pushed a commit that referenced this pull request Mar 15, 2022
* fix maximum minimum backward bug

* refine

* refine

* auto format by CI

* refine

Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org>
Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>
Co-authored-by: Houjiang Chen <chenhoujiangcug@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants