Align getitem with pytorch when index on different devices #7977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosout
requested review from
hjchen2,
BBuf,
daquexian and
jackalcooper
as code owners
BBuf
approved these changes
Apr 8, 2022
Flowingsun007
approved these changes
Apr 11, 2022
mosout
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
jackalcooper
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
mosout
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
mosout
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
mosout
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
hjchen2
reviewed
May 6, 2022
Comment on lines
+1945
to
+1957
| if (!tensor_indices.empty()) { | ||
| const auto x_device = JUST(x->device()); | ||
| for (int64_t i = 0; i < tensor_indices.size(); ++i) { | ||
| const auto tensor_index = tensor_indices[i]; | ||
| if (tensor_index == nullptr) { continue; } | ||
| const auto tensor_index_device = JUST(tensor_index->device()); | ||
| if ((tensor_index_device->type() != x_device->type()) | ||
| || (tensor_index_device->device_id() != x_device->device_id())) { | ||
| tensor_indices[i] = JUST(Copy(tensor_index, x_device->type(), x_device->device_id())); | ||
| } | ||
| } | ||
| result = JUST(ApplyAdvancedIndexing(result, tensor_indices)); | ||
| } |
There was a problem hiding this comment.
这段代码写成一个单独的函数在ApplyAdvancedIndexing中合适的位置调用吧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/Oneflow-Inc/OneTeam/issues/1184#issuecomment-1084042280