Fix scalar logical equal of bool #8924

Flowingsun007 · 2022-08-16T03:49:21Z

修复bool比较的bug，来源：https://github.com/Oneflow-Inc/OneCloud/issues/147#issuecomment-1203885669

github-actions · 2022-08-16T04:01:30Z

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

github-actions · 2022-08-17T03:32:27Z

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/8924/

github-actions · 2022-08-20T19:39:36Z

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/8924/

github-actions · 2022-08-20T19:41:45Z

Speed stats:

GPU Name: GeForce GTX 1080 

✔️ OneFlow resnet50 time: 128.7ms (= 12865.0ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 145.4ms (= 14540.1ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.13 (= 145.4ms / 128.7ms)

OneFlow resnet50 time: 75.4ms (= 7535.7ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 87.5ms (= 8752.9ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.16 (= 87.5ms / 75.4ms)

OneFlow resnet50 time: 49.1ms (= 9827.5ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 63.9ms (= 12771.6ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.30 (= 63.9ms / 49.1ms)

OneFlow resnet50 time: 36.5ms (= 7309.6ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 46.1ms (= 9225.1ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.26 (= 46.1ms / 36.5ms)

OneFlow resnet50 time: 28.5ms (= 5708.4ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 38.4ms (= 7674.8ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 1.34 (= 38.4ms / 28.5ms)

OneFlow swin dataloader time: 0.260s (= 51.934s / 200, num_workers=1)
PyTorch swin dataloader time: 0.151s (= 30.243s / 200, num_workers=1)
Relative speed: 0.582 (= 0.151s / 0.260s)

OneFlow swin dataloader time: 0.072s (= 14.446s / 200, num_workers=4)
PyTorch swin dataloader time: 0.043s (= 8.610s / 200, num_workers=4)
Relative speed: 0.596 (= 0.043s / 0.072s)

OneFlow swin dataloader time: 0.039s (= 7.765s / 200, num_workers=8)
PyTorch swin dataloader time: 0.022s (= 4.483s / 200, num_workers=8)
Relative speed: 0.577 (= 0.022s / 0.039s)

❌ OneFlow resnet50 time: 136.7ms (= 13670.7ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 163.2ms (= 16321.3ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.19 (= 163.2ms / 136.7ms)

OneFlow resnet50 time: 85.0ms (= 8496.2ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 102.3ms (= 10225.8ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.20 (= 102.3ms / 85.0ms)

OneFlow resnet50 time: 58.9ms (= 11772.7ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 88.4ms (= 17679.8ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.50 (= 88.4ms / 58.9ms)

OneFlow resnet50 time: 45.5ms (= 9102.7ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 72.2ms (= 14434.7ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.59 (= 72.2ms / 45.5ms)

OneFlow resnet50 time: 39.1ms (= 7821.0ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 67.7ms (= 13541.4ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.73 (= 67.7ms / 39.1ms)

github-actions · 2022-08-20T23:00:32Z

Speed stats:

GPU Name: GeForce GTX 1080 

✔️ OneFlow resnet50 time: 128.4ms (= 12837.2ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 145.1ms (= 14512.5ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.13 (= 145.1ms / 128.4ms)

OneFlow resnet50 time: 75.3ms (= 7534.6ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 88.2ms (= 8823.0ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.17 (= 88.2ms / 75.3ms)

OneFlow resnet50 time: 48.9ms (= 9775.2ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 55.5ms (= 11109.0ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.14 (= 55.5ms / 48.9ms)

OneFlow resnet50 time: 36.6ms (= 7313.2ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 42.0ms (= 8408.4ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.15 (= 42.0ms / 36.6ms)

OneFlow resnet50 time: 28.4ms (= 5677.7ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 40.9ms (= 8175.5ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 1.44 (= 40.9ms / 28.4ms)

OneFlow swin dataloader time: 0.411s (= 82.167s / 200, num_workers=1)
PyTorch swin dataloader time: 0.152s (= 30.426s / 200, num_workers=1)
Relative speed: 0.370 (= 0.152s / 0.411s)

OneFlow swin dataloader time: 0.070s (= 14.013s / 200, num_workers=4)
PyTorch swin dataloader time: 0.040s (= 7.909s / 200, num_workers=4)
Relative speed: 0.564 (= 0.040s / 0.070s)

OneFlow swin dataloader time: 0.040s (= 8.036s / 200, num_workers=8)
PyTorch swin dataloader time: 0.022s (= 4.460s / 200, num_workers=8)
Relative speed: 0.555 (= 0.022s / 0.040s)

❌ OneFlow resnet50 time: 136.6ms (= 13662.9ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 162.4ms (= 16237.9ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.19 (= 162.4ms / 136.6ms)

OneFlow resnet50 time: 84.9ms (= 8491.9ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 103.1ms (= 10309.2ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.21 (= 103.1ms / 84.9ms)

OneFlow resnet50 time: 58.5ms (= 11705.8ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 84.5ms (= 16909.8ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.44 (= 84.5ms / 58.5ms)

OneFlow resnet50 time: 45.9ms (= 9179.6ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 72.6ms (= 14521.6ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.58 (= 72.6ms / 45.9ms)

OneFlow resnet50 time: 39.1ms (= 7826.2ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 78.5ms (= 15705.5ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 2.01 (= 78.5ms / 39.1ms)

github-actions · 2022-08-20T23:43:34Z

CI failed when running job: cuda-misc. PR label automerge has been removed

github-actions · 2022-08-21T08:49:15Z

Speed stats:

GPU Name: GeForce GTX 1080 

✔️ OneFlow resnet50 time: 128.5ms (= 12854.0ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 143.4ms (= 14343.8ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.12 (= 143.4ms / 128.5ms)

OneFlow resnet50 time: 75.6ms (= 7564.3ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 86.8ms (= 8682.8ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.15 (= 86.8ms / 75.6ms)

OneFlow resnet50 time: 49.7ms (= 9949.9ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 54.4ms (= 10875.8ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.09 (= 54.4ms / 49.7ms)

OneFlow resnet50 time: 37.0ms (= 7399.8ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 46.2ms (= 9245.0ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.25 (= 46.2ms / 37.0ms)

OneFlow resnet50 time: 28.6ms (= 5719.3ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 36.4ms (= 7283.4ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 1.27 (= 36.4ms / 28.6ms)

OneFlow swin dataloader time: 0.422s (= 84.338s / 200, num_workers=1)
PyTorch swin dataloader time: 0.150s (= 30.006s / 200, num_workers=1)
Relative speed: 0.356 (= 0.150s / 0.422s)

OneFlow swin dataloader time: 0.069s (= 13.870s / 200, num_workers=4)
PyTorch swin dataloader time: 0.044s (= 8.805s / 200, num_workers=4)
Relative speed: 0.635 (= 0.044s / 0.069s)

OneFlow swin dataloader time: 0.040s (= 7.961s / 200, num_workers=8)
PyTorch swin dataloader time: 0.022s (= 4.306s / 200, num_workers=8)
Relative speed: 0.541 (= 0.022s / 0.040s)

❌ OneFlow resnet50 time: 136.7ms (= 13666.1ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 168.6ms (= 16858.9ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.23 (= 168.6ms / 136.7ms)

OneFlow resnet50 time: 86.1ms (= 8610.9ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 105.1ms (= 10508.3ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.22 (= 105.1ms / 86.1ms)

OneFlow resnet50 time: 58.9ms (= 11771.7ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 90.5ms (= 18100.3ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.54 (= 90.5ms / 58.9ms)

OneFlow resnet50 time: 45.8ms (= 9151.8ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 81.4ms (= 16277.2ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.78 (= 81.4ms / 45.8ms)

OneFlow resnet50 time: 39.4ms (= 7872.2ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 74.8ms (= 14966.0ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.90 (= 74.8ms / 39.4ms)

github-actions · 2022-08-21T11:12:59Z

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/8924/

github-actions · 2022-08-21T11:14:48Z

Speed stats:

GPU Name: GeForce GTX 1080 

✔️ OneFlow resnet50 time: 128.7ms (= 12869.5ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 149.6ms (= 14958.0ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.16 (= 149.6ms / 128.7ms)

OneFlow resnet50 time: 75.7ms (= 7573.3ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 86.4ms (= 8641.2ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.14 (= 86.4ms / 75.7ms)

OneFlow resnet50 time: 49.2ms (= 9843.1ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 59.8ms (= 11952.5ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.21 (= 59.8ms / 49.2ms)

OneFlow resnet50 time: 36.7ms (= 7345.3ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 40.8ms (= 8160.4ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.11 (= 40.8ms / 36.7ms)

OneFlow resnet50 time: 28.5ms (= 5709.6ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 38.6ms (= 7729.0ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 1.35 (= 38.6ms / 28.5ms)

OneFlow swin dataloader time: 0.264s (= 52.819s / 200, num_workers=1)
PyTorch swin dataloader time: 0.150s (= 30.038s / 200, num_workers=1)
Relative speed: 0.569 (= 0.150s / 0.264s)

OneFlow swin dataloader time: 0.112s (= 22.376s / 200, num_workers=4)
PyTorch swin dataloader time: 0.043s (= 8.560s / 200, num_workers=4)
Relative speed: 0.383 (= 0.043s / 0.112s)

OneFlow swin dataloader time: 0.041s (= 8.223s / 200, num_workers=8)
PyTorch swin dataloader time: 0.022s (= 4.403s / 200, num_workers=8)
Relative speed: 0.535 (= 0.022s / 0.041s)

❌ OneFlow resnet50 time: 136.6ms (= 13656.6ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 162.2ms (= 16222.6ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.19 (= 162.2ms / 136.6ms)

OneFlow resnet50 time: 85.8ms (= 8581.9ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 103.0ms (= 10297.7ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.20 (= 103.0ms / 85.8ms)

OneFlow resnet50 time: 58.3ms (= 11651.7ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 78.1ms (= 15625.6ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.34 (= 78.1ms / 58.3ms)

OneFlow resnet50 time: 45.6ms (= 9110.3ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 73.3ms (= 14654.7ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.61 (= 73.3ms / 45.6ms)

OneFlow resnet50 time: 38.9ms (= 7779.0ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 76.5ms (= 15307.0ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.97 (= 76.5ms / 38.9ms)

Flowingsun007 added 4 commits August 16, 2022 03:11

fix bool datatype of scalar_logical_equal

a301784

add test case

59a174c

add test case

984164d

refine

c02dcd6

Flowingsun007 requested review from hjchen2, BBuf, daquexian and jackalcooper as code owners August 16, 2022 03:49

Flowingsun007 added enhancement eager api labels Aug 16, 2022

BBuf approved these changes Aug 16, 2022

View reviewed changes

wyg1997 approved these changes Aug 16, 2022

View reviewed changes

Flowingsun007 enabled auto-merge (squash) August 16, 2022 03:59

Flowingsun007 requested a review from oneflow-ci-bot August 16, 2022 03:59

auto format by CI

72d7f78

Flowingsun007 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 16, 2022 04:15

Flowingsun007 added the need-clean-ccache label Aug 16, 2022

Flowingsun007 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 16, 2022 06:42

Flowingsun007 added automerge and removed need-clean-ccache labels Aug 16, 2022

Merge branch 'master' into fix_scalar_logical_equal_of_bool

7e54ae0

Flowingsun007 added the automerge label Aug 20, 2022

mergify bot added 2 commits August 20, 2022 02:10

Merge branch 'master' into fix_scalar_logical_equal_of_bool

6e5cbdd

Merge branch 'master' into fix_scalar_logical_equal_of_bool

ddbb0fa

Flowingsun007 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 20, 2022 05:16

Merge branch 'master' into fix_scalar_logical_equal_of_bool

dba7607

Flowingsun007 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 20, 2022 06:13

mergify bot added 3 commits August 20, 2022 07:52

Merge branch 'master' into fix_scalar_logical_equal_of_bool

fd86666

Merge branch 'master' into fix_scalar_logical_equal_of_bool

fe17b1d

Merge branch 'master' into fix_scalar_logical_equal_of_bool

838bd09

oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 20, 2022 17:34

Merge branch 'master' into fix_scalar_logical_equal_of_bool

0400629

oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 20, 2022 22:22

Merge branch 'master' into fix_scalar_logical_equal_of_bool

06393b5

github-actions bot removed the automerge label Aug 20, 2022

Merge branch 'master' into fix_scalar_logical_equal_of_bool

d7fb10a

Flowingsun007 added the automerge label Aug 21, 2022

Merge branch 'master' into fix_scalar_logical_equal_of_bool

cf09095

Flowingsun007 merged commit e3a9b89 into master Aug 21, 2022

Flowingsun007 deleted the fix_scalar_logical_equal_of_bool branch August 21, 2022 11:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix scalar logical equal of bool #8924

Fix scalar logical equal of bool #8924

Flowingsun007 commented Aug 16, 2022 •

edited

Loading

github-actions bot commented Aug 16, 2022

github-actions bot commented Aug 17, 2022

github-actions bot commented Aug 20, 2022

github-actions bot commented Aug 20, 2022

github-actions bot commented Aug 20, 2022

github-actions bot commented Aug 20, 2022

github-actions bot commented Aug 21, 2022

github-actions bot commented Aug 21, 2022

github-actions bot commented Aug 21, 2022

Fix scalar logical equal of bool #8924

Fix scalar logical equal of bool #8924

Conversation

Flowingsun007 commented Aug 16, 2022 • edited Loading

github-actions bot commented Aug 16, 2022

github-actions bot commented Aug 17, 2022

github-actions bot commented Aug 20, 2022

github-actions bot commented Aug 20, 2022

github-actions bot commented Aug 20, 2022

github-actions bot commented Aug 20, 2022

github-actions bot commented Aug 21, 2022

github-actions bot commented Aug 21, 2022

github-actions bot commented Aug 21, 2022

Flowingsun007 commented Aug 16, 2022 •

edited

Loading