Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cumprod grad get sbp #8929

Merged
merged 5 commits into from
Aug 18, 2022
Merged

Fix cumprod grad get sbp #8929

merged 5 commits into from
Aug 18, 2022

Conversation

wyg1997
Copy link
Contributor

@wyg1997 wyg1997 commented Aug 16, 2022

fix #8920

@wyg1997 wyg1997 requested a review from oneflow-ci-bot August 16, 2022 10:17
@wyg1997 wyg1997 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 17, 2022 06:41
@github-actions
Copy link
Contributor

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/8929/

@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: GeForce GTX 1080 

✔️ OneFlow resnet50 time: 128.5ms (= 12851.0ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 142.4ms (= 14236.6ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.11 (= 142.4ms / 128.5ms)

OneFlow resnet50 time: 75.2ms (= 7525.0ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 83.4ms (= 8335.2ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.11 (= 83.4ms / 75.2ms)

OneFlow resnet50 time: 48.4ms (= 9677.1ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 56.9ms (= 11387.7ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.18 (= 56.9ms / 48.4ms)

OneFlow resnet50 time: 36.0ms (= 7195.0ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 41.2ms (= 8243.4ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.15 (= 41.2ms / 36.0ms)

OneFlow resnet50 time: 28.1ms (= 5622.5ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 38.0ms (= 7609.0ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 1.35 (= 38.0ms / 28.1ms)

OneFlow swin dataloader time: 0.265s (= 53.023s / 200, num_workers=1)
PyTorch swin dataloader time: 0.151s (= 30.112s / 200, num_workers=1)
Relative speed: 0.568 (= 0.151s / 0.265s)

OneFlow swin dataloader time: 0.071s (= 14.264s / 200, num_workers=4)
PyTorch swin dataloader time: 0.042s (= 8.314s / 200, num_workers=4)
Relative speed: 0.583 (= 0.042s / 0.071s)

OneFlow swin dataloader time: 0.040s (= 8.020s / 200, num_workers=8)
PyTorch swin dataloader time: 0.024s (= 4.831s / 200, num_workers=8)
Relative speed: 0.602 (= 0.024s / 0.040s)

❌ OneFlow resnet50 time: 136.4ms (= 13639.1ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 163.7ms (= 16370.5ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.20 (= 163.7ms / 136.4ms)

OneFlow resnet50 time: 84.4ms (= 8443.0ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 112.3ms (= 11232.3ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.33 (= 112.3ms / 84.4ms)

OneFlow resnet50 time: 57.6ms (= 11520.2ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 81.5ms (= 16296.9ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.41 (= 81.5ms / 57.6ms)

OneFlow resnet50 time: 45.1ms (= 9025.8ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 70.0ms (= 13992.9ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.55 (= 70.0ms / 45.1ms)

OneFlow resnet50 time: 39.2ms (= 7849.0ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 68.6ms (= 13711.3ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.75 (= 68.6ms / 39.2ms)

@wyg1997 wyg1997 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 17, 2022 09:32
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 17, 2022 18:39
@github-actions
Copy link
Contributor

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/8929/

@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: GeForce GTX 1080 

✔️ OneFlow resnet50 time: 128.3ms (= 12833.8ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 142.4ms (= 14235.4ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.11 (= 142.4ms / 128.3ms)

OneFlow resnet50 time: 75.3ms (= 7532.8ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 86.2ms (= 8617.0ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.14 (= 86.2ms / 75.3ms)

OneFlow resnet50 time: 48.3ms (= 9666.3ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 56.0ms (= 11203.0ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.16 (= 56.0ms / 48.3ms)

OneFlow resnet50 time: 35.7ms (= 7148.4ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 41.7ms (= 8345.0ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.17 (= 41.7ms / 35.7ms)

OneFlow resnet50 time: 28.1ms (= 5619.4ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 35.8ms (= 7157.1ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 1.27 (= 35.8ms / 28.1ms)

OneFlow swin dataloader time: 0.266s (= 53.290s / 200, num_workers=1)
PyTorch swin dataloader time: 0.156s (= 31.102s / 200, num_workers=1)
Relative speed: 0.584 (= 0.156s / 0.266s)

OneFlow swin dataloader time: 0.071s (= 14.191s / 200, num_workers=4)
PyTorch swin dataloader time: 0.040s (= 8.063s / 200, num_workers=4)
Relative speed: 0.568 (= 0.040s / 0.071s)

OneFlow swin dataloader time: 0.062s (= 12.322s / 200, num_workers=8)
PyTorch swin dataloader time: 0.022s (= 4.385s / 200, num_workers=8)
Relative speed: 0.356 (= 0.022s / 0.062s)

❌ OneFlow resnet50 time: 136.5ms (= 13650.5ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 160.7ms (= 16069.9ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.18 (= 160.7ms / 136.5ms)

OneFlow resnet50 time: 84.4ms (= 8437.8ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 101.4ms (= 10140.7ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.20 (= 101.4ms / 84.4ms)

OneFlow resnet50 time: 57.6ms (= 11526.4ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 88.1ms (= 17620.7ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.53 (= 88.1ms / 57.6ms)

OneFlow resnet50 time: 45.3ms (= 9055.6ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 75.4ms (= 15082.2ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.67 (= 75.4ms / 45.3ms)

OneFlow resnet50 time: 39.0ms (= 7797.1ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 65.7ms (= 13138.0ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.68 (= 65.7ms / 39.0ms)

@mergify mergify bot merged commit cd3b126 into master Aug 18, 2022
@mergify mergify bot deleted the fix-cumprod_grad_get_sbp branch August 18, 2022 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flowingsun007 Flowingsun007 Flowingsun007 approved these changes

@MARD1NO MARD1NO MARD1NO approved these changes

@BBuf BBuf Awaiting requested review from BBuf

@daquexian daquexian Awaiting requested review from daquexian

@jackalcooper jackalcooper Awaiting requested review from jackalcooper

@oneflow-ci-bot oneflow-ci-bot Awaiting requested review from oneflow-ci-bot

Assignees
No one assigned
Labels
automerge bug op
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flow.cumprod不支持sbp模式，或sbp模式实现存在bug
3 participants
@wyg1997 @Flowingsun007 @MARD1NO