Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add oneflow.cuda.get_rng_state and oneflow.cuda.get_rng_state_all api #9760

Merged
merged 6 commits into from
Jan 16, 2023
Merged

add oneflow.cuda.get_rng_state and oneflow.cuda.get_rng_state_all api #9760

merged 6 commits into from
Jan 16, 2023

Conversation

BBuf
Copy link
Contributor

@BBuf BBuf commented Jan 16, 2023

#close #9757

截图：

图片

图片

@BBuf BBuf requested a review from oneflow-ci-bot January 16, 2023 14:26
@github-actions
Copy link
Contributor

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

@github-actions
Copy link
Contributor

Speed stats:

@github-actions
Copy link
Contributor

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: GeForce GTX 1080 









❌ OneFlow resnet50 time: 139.7ms (= 13965.9ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 160.4ms (= 16037.2ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.15 (= 160.4ms / 139.7ms)

OneFlow resnet50 time: 85.0ms (= 8495.2ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 101.2ms (= 10115.8ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.19 (= 101.2ms / 85.0ms)

OneFlow resnet50 time: 57.9ms (= 11585.2ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 79.3ms (= 15868.1ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.37 (= 79.3ms / 57.9ms)

OneFlow resnet50 time: 50.0ms (= 9998.2ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 74.1ms (= 14811.6ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.48 (= 74.1ms / 50.0ms)

OneFlow resnet50 time: 39.9ms (= 7975.1ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 67.3ms (= 13456.5ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.69 (= 67.3ms / 39.9ms)

@github-actions
Copy link
Contributor

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/9760/

@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: GeForce GTX 1080 









❌ OneFlow resnet50 time: 139.5ms (= 13948.6ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 159.9ms (= 15991.6ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.15 (= 159.9ms / 139.5ms)

OneFlow resnet50 time: 87.6ms (= 8763.6ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 102.5ms (= 10254.7ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.17 (= 102.5ms / 87.6ms)

OneFlow resnet50 time: 59.9ms (= 11989.2ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 78.7ms (= 15746.2ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.31 (= 78.7ms / 59.9ms)

OneFlow resnet50 time: 45.8ms (= 9162.2ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 70.1ms (= 14012.1ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.53 (= 70.1ms / 45.8ms)

OneFlow resnet50 time: 42.5ms (= 8503.0ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 68.0ms (= 13605.4ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.60 (= 68.0ms / 42.5ms)

@github-actions
Copy link
Contributor

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/9760/

@mergify mergify bot merged commit 896330d into master Jan 16, 2023
@mergify mergify bot deleted the add_cuda_random branch January 16, 2023 22:43
daquexian
daquexian reviewed Mar 3, 2023
View reviewed changes
python/oneflow/cuda/random.py
idx = device.index
if idx is None:
idx = current_device()
default_generator = flow.cuda.default_generators[idx]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lightning 适配中发现代码运行到这里会报错，因为 flow.cuda 下并没有 default_generators 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daquexian daquexian daquexian approved these changes

@doombeaker doombeaker doombeaker approved these changes

@jackalcooper jackalcooper Awaiting requested review from jackalcooper

@oneflow-ci-bot oneflow-ci-bot Awaiting requested review from oneflow-ci-bot

Assignees
No one assigned
Labels
api automerge bug eager enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: module 'oneflow.cuda' has no attribute 'get_rng_state'
4 participants
@BBuf @doombeaker @daquexian @oneflow-ci-bot