Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tensor.baddbmm #9918

Merged
merged 5 commits into from
Mar 2, 2023
Merged

add tensor.baddbmm #9918

merged 5 commits into from
Mar 2, 2023

Conversation

marigoold
Copy link
Contributor

No description provided.

@marigoold marigoold requested a review from xiezipeng-ML March 1, 2023 13:13
@marigoold marigoold requested a review from oneflow-ci-bot March 1, 2023 14:25
@marigoold marigoold enabled auto-merge (squash) March 1, 2023 14:25
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

@marigoold marigoold requested review from oneflow-ci-bot and removed request for oneflow-ci-bot March 1, 2023 14:28
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

@marigoold marigoold requested review from oneflow-ci-bot and removed request for oneflow-ci-bot March 1, 2023 15:07
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Speed stats: 
GPU Name: GeForce GTX 1080 

❌ OneFlow resnet50 time: 141.2ms (= 14123.0ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 143.9ms (= 14394.9ms / 100, input_shape=[16, 3, 224, 224])
❌ Relative speed: 1.02 (= 143.9ms / 141.2ms)

OneFlow resnet50 time: 81.6ms (= 8158.6ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 87.1ms (= 8713.0ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.07 (= 87.1ms / 81.6ms)

OneFlow resnet50 time: 50.8ms (= 10160.7ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 55.7ms (= 11141.4ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.10 (= 55.7ms / 50.8ms)

OneFlow resnet50 time: 33.5ms (= 6690.2ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 42.2ms (= 8442.1ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.26 (= 42.2ms / 33.5ms)

OneFlow resnet50 time: 26.1ms (= 5216.0ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 37.2ms (= 7433.8ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 1.43 (= 37.2ms / 26.1ms)

OneFlow swin dataloader time: 0.235s (= 46.905s / 200, num_workers=1)
PyTorch swin dataloader time: 0.153s (= 30.596s / 200, num_workers=1)
Relative speed: 0.652 (= 0.153s / 0.235s)

OneFlow swin dataloader time: 0.069s (= 13.893s / 200, num_workers=4)
PyTorch swin dataloader time: 0.045s (= 8.912s / 200, num_workers=4)
Relative speed: 0.641 (= 0.045s / 0.069s)

OneFlow swin dataloader time: 0.042s (= 8.333s / 200, num_workers=8)
PyTorch swin dataloader time: 0.022s (= 4.357s / 200, num_workers=8)
Relative speed: 0.523 (= 0.022s / 0.042s)

❌ OneFlow resnet50 time: 152.6ms (= 15264.8ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 165.9ms (= 16589.3ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
❌ Relative speed: 1.09 (= 165.9ms / 152.6ms)

OneFlow resnet50 time: 92.5ms (= 9247.8ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 102.7ms (= 10274.2ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.11 (= 102.7ms / 92.5ms)

OneFlow resnet50 time: 60.4ms (= 12078.7ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 87.6ms (= 17515.8ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.45 (= 87.6ms / 60.4ms)

OneFlow resnet50 time: 42.3ms (= 8465.7ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 71.2ms (= 14247.6ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.68 (= 71.2ms / 42.3ms)

OneFlow resnet50 time: 35.7ms (= 7132.5ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 68.7ms (= 13732.5ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.93 (= 68.7ms / 35.7ms)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

CI failed when running job: cpu-module. PR label automerge has been removed

@github-actions github-actions bot removed the automerge label Mar 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

Speed stats: 
GPU Name: GeForce GTX 1080 

❌ OneFlow resnet50 time: 141.0ms (= 14104.9ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 143.2ms (= 14323.8ms / 100, input_shape=[16, 3, 224, 224])
❌ Relative speed: 1.02 (= 143.2ms / 141.0ms)

OneFlow resnet50 time: 80.7ms (= 8070.8ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 85.9ms (= 8594.2ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.06 (= 85.9ms / 80.7ms)

OneFlow resnet50 time: 50.3ms (= 10058.7ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 61.7ms (= 12340.3ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.23 (= 61.7ms / 50.3ms)

OneFlow resnet50 time: 32.8ms (= 6555.6ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 50.5ms (= 10106.6ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.54 (= 50.5ms / 32.8ms)

OneFlow resnet50 time: 24.7ms (= 4931.9ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 39.8ms (= 7956.8ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 1.61 (= 39.8ms / 24.7ms)

OneFlow swin dataloader time: 0.237s (= 47.441s / 200, num_workers=1)
PyTorch swin dataloader time: 0.148s (= 29.646s / 200, num_workers=1)
Relative speed: 0.625 (= 0.148s / 0.237s)

OneFlow swin dataloader time: 0.069s (= 13.857s / 200, num_workers=4)
PyTorch swin dataloader time: 0.043s (= 8.515s / 200, num_workers=4)
Relative speed: 0.614 (= 0.043s / 0.069s)

OneFlow swin dataloader time: 0.041s (= 8.173s / 200, num_workers=8)
PyTorch swin dataloader time: 0.022s (= 4.425s / 200, num_workers=8)
Relative speed: 0.541 (= 0.022s / 0.041s)

❌ OneFlow resnet50 time: 152.8ms (= 15278.3ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 166.6ms (= 16664.1ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
❌ Relative speed: 1.09 (= 166.6ms / 152.8ms)

OneFlow resnet50 time: 92.3ms (= 9231.3ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 102.5ms (= 10253.2ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.11 (= 102.5ms / 92.3ms)

OneFlow resnet50 time: 60.2ms (= 12039.6ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 80.4ms (= 16072.7ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.33 (= 80.4ms / 60.2ms)

OneFlow resnet50 time: 42.0ms (= 8392.7ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 69.5ms (= 13897.5ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.66 (= 69.5ms / 42.0ms)

OneFlow resnet50 time: 36.2ms (= 7235.1ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 74.5ms (= 14897.8ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 2.06 (= 74.5ms / 36.2ms)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/9918/

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

CI failed when running job: cuda-misc. PR label automerge has been removed

@marigoold marigoold merged commit 8ba8eb6 into master Mar 2, 2023
@marigoold marigoold deleted the dev_add_tensor_baddbmm branch March 2, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BBuf BBuf BBuf approved these changes

@xiezipeng-ML xiezipeng-ML xiezipeng-ML approved these changes

@doombeaker doombeaker Awaiting requested review from doombeaker doombeaker is a code owner

@daquexian daquexian Awaiting requested review from daquexian

@oneflow-ci-bot oneflow-ci-bot Awaiting requested review from oneflow-ci-bot

Assignees
No one assigned
Labels
api automerge enhancement python test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marigoold @BBuf @xiezipeng-ML @oneflow-ci-bot