Add senet and results docstring #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github.com:Oneflow-Inc/vision into add-SEModule-doc add SEModule docstring
Aries-chen
added
enhancement
rentainhe
reviewed
Feb 18, 2022
flowvision/models/senet.py
Outdated
| @ModelCreator.register_model | ||
| def senet154(pretrained=False, progress=True, **kwargs): | ||
| """ | ||
| Constructs the senet154 model trained on ImageNet2012. |
There was a problem hiding this comment.
在论文中确实用 ResNet-152、 SENet-154 来比较，但是在代码中，可以参见 models 下已有的模型
- 代码中的函数 senet150 类比 resnet50、resnet101 等，表示该模型自身的网络， 而非有额外的添加如 se_inception_v3
pytorch 和其他几个大佬也是如此命名，所以我认为函数命名应该是没问题的。 - 论文中的 SENet-154 类比 ResNet-152，使用了大写通常用于阐述
假如你引用的只是第300行，那我认可建议，改为 Constructs the SENet-154 model trained on ImageNet2012.
flowvision/models/senet.py
Outdated
| @ModelCreator.register_model | ||
| def se_resent50(pretrained=False, progress=True, **kwargs): | ||
| """ | ||
| Constructs the se-resent50 model trained on ImageNet2012. |
|
还需要更新一下README里的那个模型，加一个SENet进去 @Aries-chen |
rentainhe
reviewed
Feb 18, 2022
Changelog 和readme更新一下，还有速度？ |
README更新一下，速度测试加上，ChangeLog这边还没弄好2333，之后再加也行，然后记得先合并一下主分支解决冲突 |
…nd-results-docstring
|
已更新 |
rentainhe
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加了 senet 的多个子模型以及他们的文档和测试结果
@kaijieshi7