update feature posts #33
Conversation
caovv62
force-pushed
the
feature/ODE-115-create-feature-posts-of-blog
branch
from
6ed82f9
to
2474e66
Compare
resources/css/index.css
Outdated
| } | ||
| #feature-posts .card-list { | ||
| width: 100%; | ||
| /*display: flex;*/ |
There was a problem hiding this comment.
Remove comment if it is not necessary.
There was a problem hiding this comment.
Fix similar error in your PR.
index.html
Outdated
| <div class="card-list"></div> | ||
| <div class="card-list"></div> | ||
| <br> | ||
| <div style="text-align:center"> |
There was a problem hiding this comment.
According to our coding convention, style shouldn't be inline a tag.
Name your div as class or id, define its style in .css file.
index.html
Outdated
| <script src="resources/js/responsive.js"></script> | ||
| <script src="resources/js/cover.js"></script> | ||
| <script src="resources/js/feature_post.js"></script> |
There was a problem hiding this comment.
resources/js/feature_post.js
Outdated
| @@ -0,0 +1,188 @@ | |||
| const feature_post = [ | |||
There was a problem hiding this comment.
Viết thế này, ví dụ như mình có 5, 7 hay số feature posts không chia hết cho 3 thì sao anh?
resources/js/feature_post.js
Outdated
|
|
||
| var listcard = document.getElementById('feature-posts').getElementsByClassName('card-list')[2]; | ||
| for (var i = 0; i < feature_post_2.length; i++) { | ||
| var icon = document.createElement('I'); |
There was a problem hiding this comment.
Các thẻ i, div, img viết hoa lên hết làm gì nhỉ?
|
There's no responsive (for more specific, mobile size) in your implementation. |
resources/css/card.css
Outdated
| padding-left: -10px; | ||
| } | ||
|
|
||
| .card-container .card { |
There was a problem hiding this comment.
No tab before element name
resources/css/card.css
Outdated
| .card-container .card { | ||
| width: 100%; | ||
| height: 100%; | ||
| background-color: #fff; |
There was a problem hiding this comment.
6 bit-hex color pls
resources/css/responsive.css
Outdated
| } | ||
| /* feature-post */ | ||
| @media screen and (min-width: 320px) { | ||
| .card-list .card-container { |
resources/js/feature_post.js
Outdated
| slides[slideIndex-1].style.display = "flex"; | ||
| dots[slideIndex-1].className += "active"; | ||
| } | ||
|
|
There was a problem hiding this comment.
No newline
And if you have time, please refactor your JS implementation, it's too complicated for a slider
Check again your slider UI. It has bugs. Next time. please check thoroughly before making a Pull Request
nguyenvl179
force-pushed
the
feature/ODE-115-create-feature-posts-of-blog
branch
from
2abfd9b
to
f633164
Compare
create feature posts of blog