Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add docs #2

Merged
merged 3 commits into from
Aug 12, 2023
Merged

add docs #2

merged 3 commits into from
Aug 12, 2023

Conversation

themonarchoftime
Copy link
Contributor

:3

OoLunar
OoLunar approved these changes Aug 12, 2023
View reviewed changes
Copy link
Owner

@OoLunar OoLunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much!

.github/docs.yml Outdated
- name: Setup .NET
uses: actions/setup-dotnet@v3
with:
dotnet-version: 7.0.103
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use .NET 8, this might break.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...can i use preview versions with setup-dotnet?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HyperSharp/.github/workflows/build-commit.yml

Lines 29 to 32 in e9823cc

- name: Setup .NET
uses: actions/setup-dotnet@v3
with:
dotnet-version: 8

@OoLunar OoLunar self-assigned this Aug 12, 2023
@OoLunar OoLunar added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 12, 2023
@OoLunar
Copy link
Owner

OoLunar commented Aug 12, 2023

LGTM. Thank you!

@OoLunar OoLunar merged commit 95dd682 into OoLunar:master Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OoLunar OoLunar OoLunar approved these changes

Assignees

@OoLunar OoLunar

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@themonarchoftime @OoLunar