Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting to shuffle the river exit in Gerudo Valley #1830

Merged
merged 2 commits into from
Jan 8, 2023

Conversation

fenhl
Copy link
Collaborator

@fenhl fenhl commented Dec 15, 2022

This adds a toggle to shuffle the exit down the river in Gerudo Valley as a one-way entrance, behaving like an owl drop but for both ages. The exit's vanilla target entrance at Lake Hylia also becomes a valid target for all one-way entrance types regardless of the setting, which is consistent with how other types of entrances are handled.

I propose this as an alternative to the current behavior on @Roman971's branch, where this entrance is included in the pool of overworld entrances if entrances are decoupled. Decoupled seems like a fairly unpopular setting even among ER players (for example, it's excluded from the RSL weights, and there was a tournament with a “full entrance randomizer” theme that didn't use the setting), so this setting removes the requirement to use decoupled in order to shuffle this exit.

This PR also includes a minor fix to how hint areas are calculated: The algorithm will now prefer regular entrance types over spawns, owl drops, warp songs, and the new OverworldOneWay type, which ensures that a region without its own hint area that's reachable via both a one-way and a regular entrance will be considered part of the hint area of the regular entrance.

@fenhl
Copy link
Collaborator Author

fenhl commented Dec 15, 2022

Any ideas on the CI failure? Doesn't seem related to this PR.

@Cuphat
Copy link
Collaborator

Cuphat commented Dec 15, 2022

Any ideas on the CI failure? Doesn't seem related to this PR.

The 3.6 failure seems to be related to this PR:
SettingsList.UnmappedSettingError: shuffle_gerudo_valley_river_exit is defined but is not in the settings map. Add it to the settings_mapping or set the gui_text to None to suppress.

The 3.x failure is indeed not related - it's a bug with Python 3.11.1 (python/cpython#100098), which seems to be what GitHub Actions is using now for 3.x.

@Cuphat
Copy link
Collaborator

Cuphat commented Dec 22, 2022

I'd say my only real concern is that this is a setting that only concerns a single entrance. What happens if it is enabled alone, with no other ER settings? I'd assume that it gets randomized to itself, right? Since it is tied to multiple settings and thus no easy way to disable when irrelevant, I'd recommend listing which ER pools/settings it works with in the tooltip.

I'm not personally super familiar with ER, so correct me if I am wrong on any of that.

@fenhl
Copy link
Collaborator Author

fenhl commented Dec 22, 2022

It behaves like randomized spawns, warp songs, or owl drops: unshuffled entrances are included as possible targets.

@Cuphat
Copy link
Collaborator

Cuphat commented Dec 22, 2022

Ah, right. Fair enough.

@Cuphat Cuphat added the Component: Setting specific to setting(s) label Jan 2, 2023
Copy link
Collaborator

@cjohnson57 cjohnson57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this behavior seems weird to me, but I guess as long as it's consistent it's fine.

"entrances":                 {
    "GV Lower Stream -> Lake Hylia": {"region": "Market Back Alley", "from": "Market Man in Green House"}
  },

@cjohnson57 cjohnson57 merged commit 31969d3 into OoTRandomizer:Dev Jan 8, 2023
@fenhl fenhl deleted the shuffle-gv-river-exit branch January 8, 2023 00:07
@fenhl fenhl added this to the 8.0 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Setting specific to setting(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants