Setting to shuffle the river exit in Gerudo Valley #1830
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a toggle to shuffle the exit down the river in Gerudo Valley as a one-way entrance, behaving like an owl drop but for both ages. The exit's vanilla target entrance at Lake Hylia also becomes a valid target for all one-way entrance types regardless of the setting, which is consistent with how other types of entrances are handled.
I propose this as an alternative to the current behavior on @Roman971's branch, where this entrance is included in the pool of overworld entrances if entrances are decoupled. Decoupled seems like a fairly unpopular setting even among ER players (for example, it's excluded from the RSL weights, and there was a tournament with a “full entrance randomizer” theme that didn't use the setting), so this setting removes the requirement to use decoupled in order to shuffle this exit.
This PR also includes a minor fix to how hint areas are calculated: The algorithm will now prefer regular entrance types over spawns, owl drops, warp songs, and the new
OverworldOneWay
type, which ensures that a region without its own hint area that's reachable via both a one-way and a regular entrance will be considered part of the hint area of the regular entrance.