Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ocarina buttons on the path of time #2203

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

fenhl
Copy link
Collaborator

@fenhl fenhl commented Apr 16, 2024

We forgot to add the ocarina button items required to play Song of Time to the Door of Time goal, so they currently behave incorrectly with respect to the goal lock and appear on later goals such as path to the key. This PR fixes that.

@fenhl fenhl added Type: Bug Something isn't working Status: Needs Review Someone should be looking at it Component: Hints related to how we help the player Status: Needs Testing Probably should be tested labels Apr 16, 2024
@r0bd0g
Copy link

r0bd0g commented Apr 17, 2024

Shouldn't all items woth to get behind dot already be included in path of time? Unless I guess the code was only checking for ToT access, and then including everything you might need in the ToT itself separately... By including these items like you have done here I think it will mean that all reachable sot note items (and any items woth to reach any of those items without going adult) could end up on path of time. I kind of feel like the path of time goal might be a bit overzealous in including all copies of these items like this? But I'm not sure what to do about it...

@fenhl
Copy link
Collaborator Author

fenhl commented Apr 17, 2024

This has previously been discussed in #1529. The tl;dr is that:

  • We include all copies of the items required to play Song of Time in the goal for consistency with other item-based goals (e.g. tokens).
  • We check for access to the Temple of Time region, not Beyond Door of Time, so we can place a goal lock to enforce all copies of the required items being reachable before the Door of Time in AGR.

@fenhl fenhl removed the Status: Needs Testing Probably should be tested label Sep 15, 2024
@fenhl fenhl removed the Status: Needs Review Someone should be looking at it label Oct 5, 2024
@fenhl fenhl added this to the next milestone Oct 5, 2024
@fenhl fenhl merged commit 5016b88 into OoTRandomizer:Dev Oct 5, 2024
3 checks passed
@fenhl fenhl deleted the ocarina-buttons-path-of-time branch October 5, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Hints related to how we help the player Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants