Document wonder_talk2 and remove the ones in Thieves' hideout #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to continue to jumpslash into these for years to come. |
|
You have to jumpslash anyway to power crouch stab during the fight so it doesn't lose time overall 😄 |
fenhl
added
Type: Enhancement
fenhl
requested changes
Jun 5, 2024
Co-authored-by: Fenhl <fenhl@fenhl.net>
fenhl
approved these changes
Jun 6, 2024
fenhl
removed
Status: Waiting for Author
fenhl
added
Status: Waiting for Release
fenhl
added a commit
that referenced
this pull request
Sep 30, 2024
|
Merged in 8de7593. |
fenhl
removed
the
Status: Waiting for Release
|
Got the PRs mixed up here somehow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wonder_talk2 is an actor that displays a textbox when near a certain spot, either automatically or by pressing A (button turns to Check). They're mostly present at the start of Shadow Temple and in every room of Gerudo Training Ground, and have been removed in randomizer years ago for convenience.
This PR adds information on how they are removed, move this process out of Patches.py in Cutscenes.py (it's not really cutscenes but it fits here imo), and use the same method to remove the ones in Thieves' Hideout when you get near a Carpenter's cell :
Hey, you! Young man, over there!
Look over here, inside the cell!
The wonder_talk2 at the Crater Fairy entrance was patched differently from the other ones, but as far as i can see, there's no real advantage to this, so i changed it to use the same method as the other ones.