Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Timesaver option : Fast Shadow Boat #2239

Open
wants to merge 2 commits into
base: Dev
Choose a base branch
from
Open

New Timesaver option : Fast Shadow Boat #2239

wants to merge 2 commits into from

Conversation

GSKirox
Copy link
Collaborator

@GSKirox GSKirox commented Jun 6, 2024

This new option massively speeds up the boat ride sequence from around 1 min to 10 sec.
The cutscene at the start has been changed to both :

  • Better fit the new behaviour by changing up the starting camera view and cutting the length short.
  • Last long enough to prevent jumping directly to the skulltula on the left, which would break logic.
2024-05-31_15-06-13.mp4

fenhl
fenhl requested changes Jun 7, 2024
View reviewed changes
Cutscenes.py Outdated Show resolved Hide resolved
SettingsList.py Show resolved Hide resolved
@fenhl fenhl added Type: Enhancement New feature or request Status: Waiting for Author Changes or response requested Status: Needs Review Someone should be looking at it Component: Setting specific to setting(s) Status: Under Consideration Developers are considering whether to accept or decline the feature described Component: Patching Affects the patching of the ROM labels Jun 7, 2024
@GSKirox
Copy link
Collaborator Author

GSKirox commented Jun 7, 2024

Impoved the cutscene viewpoint with help from flagrama !

2024-06-07.19-10-36.mp4

@fenhl fenhl removed Status: Waiting for Author Changes or response requested Status: Needs Review Someone should be looking at it labels Jun 7, 2024
@fenhl fenhl mentioned this pull request Aug 20, 2024
Open
@fenhl fenhl linked an issue Aug 20, 2024 that may be closed by this pull request
Speed up Master Sword cutscenes and Shadow boat #922
Open
@fenhl
Copy link
Collaborator

fenhl commented Aug 22, 2024

Would it make sense to enable this setting in the Easy Mode preset?

@fenhl fenhl added Status: Waiting for Release This PR is ready for merge, but we're holding off on it until after the next release and removed Status: Under Consideration Developers are considering whether to accept or decline the feature described labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fenhl fenhl fenhl approved these changes

Assignees
No one assigned
Labels
Component: Patching Affects the patching of the ROM Component: Setting specific to setting(s) Status: Waiting for Release This PR is ready for merge, but we're holding off on it until after the next release Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Speed up Master Sword cutscenes and Shadow boat
2 participants
@GSKirox @fenhl