Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Item.unshuffled_dungeon_item for TCGSmallKeyRing #2320

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

fenhl
Copy link
Collaborator

@fenhl fenhl commented Oct 23, 2024

Fixes a copy/paste error from #2317 that didn't get caught by the code review, causing TCG keyrings to never be considered “unshuffled dungeon items” for the purpose of hint wording, and hideout keyrings to be considered unshuffled dungeon items if TCG shuffle was off.

@fenhl fenhl added Type: Bug Something isn't working Status: Needs Review Someone should be looking at it Component: Hints related to how we help the player Status: Needs Testing Probably should be tested labels Oct 23, 2024
Copy link
Collaborator

@GSKirox GSKirox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops

@fenhl fenhl removed the Status: Needs Review Someone should be looking at it label Oct 23, 2024
@fenhl fenhl removed the Status: Needs Testing Probably should be tested label Nov 18, 2024
@fenhl fenhl added this to the next milestone Nov 18, 2024
@fenhl fenhl merged commit 6d8029f into OoTRandomizer:Dev Nov 18, 2024
3 checks passed
@fenhl fenhl deleted the unshuffled-tcg-keyring branch November 18, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Hints related to how we help the player Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants