Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New QoL setting : textbox to equip new swords/shields/tunic when finding them #2335

Open
wants to merge 2 commits into
base: Dev
Choose a base branch
from

Conversation

GSKirox
Copy link
Collaborator

@GSKirox GSKirox commented Nov 20, 2024

image

Adds a new setting in Timesavers that will open a two choice textbox to ask the player if they want to equip the new sword/shield/tunic they just found, when appropriate.
Appropriate meaning Link is currently the right age to use the equipment, and has not already equipped one.
Small exception for Hylian shield, that will only be prompted if Link has not equipped another shield already, regardless of age, since the occasions to want to un-equip either Deku shield or Mirror shield are pretty rare.

@fenhl fenhl added Type: Enhancement New feature or request Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Review Someone should be looking at it Component: Setting specific to setting(s) Status: Needs Testing Probably should be tested Status: Under Consideration Developers are considering whether to accept or decline the feature described labels Nov 20, 2024
@r0bd0g
Copy link

r0bd0g commented Nov 20, 2024

Something that's always seemed strange to me is, if you start with a deku shield, it auto equips. If you find a hylian shield and then go adult for the first time, that auto equips (vanilla feature). But if you find a deku shield and then go child for the first time, that doesn't auto equip. But on the other hand I kind of don't want the deku shield ever auto equipping because I don't know if I might be going near fire before I'd actually want to use the shield, so I prefer to wait to equip until the shield is definitely going to save me time if I equip it. I feel like this dialog is going to force me to always equip it right away since it makes it so it always saves time to equip it now. I guess it's a setting, right, I don't have to enable it? Do other people want this?

(Another weird auto equip is the giants knife on adult starts.)

@GSKirox
Copy link
Collaborator Author

GSKirox commented Nov 20, 2024

Well the point of making this a choice textbox is that it doesn't force you to equip. If you have a chance to go near Fire as child later in the seed, it makes sense to just choose no and tank the few seconds potential loss to a less conservative player.

A solution could be to enable to un-equip shields, like OOTxMM does 👀 maybe behind another paired setting?

It is a setting yes, and not Cosmetics, so it'd be up to tournament mods and race mods to choose it for their races.

I agree auto equips could use a brush up, the giant knife one is particularly goofy.

@r0bd0g
Copy link

r0bd0g commented Nov 20, 2024

Honestly vanilla OoT not letting you unequip shields feels like a missing feature. (It doesn't even need to be a setting. If you don't want to unequip shields then just don't unequip it.)

@flagrama
Copy link

I sort of agree with r0bd0g. But, I feel like there should be a certain restrictions to try to keep the unequiping vanillaish.

  1. You should be able to select an empty shield slot appropriate for the age to unequip. So if you have both shields for an age, you need to have one of them equipped.
  2. You need to have obtained the shield to use that slot. So child can only unequip if you have found both a Deku and Hylian shield but lost one (or both) and adult can only unequip if they lost the hylian shield after finding the mirror shield.

@r0bd0g
Copy link

r0bd0g commented Nov 21, 2024

I was thinking you'd just click the currently equipped shield >_>
(That scheme is way too complicated.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ASM/C Changes some internals of the ASM/C libraries Component: Setting specific to setting(s) Status: Needs Review Someone should be looking at it Status: Needs Testing Probably should be tested Status: Under Consideration Developers are considering whether to accept or decline the feature described Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants