-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TC] Add helper formatters for data dictionary #535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (4)
- examples/seeder_example/section_control_implement_sim.cpp: Language not supported
- isobus/include/isobus/isobus/isobus_data_dictionary.hpp: Language not supported
- isobus/include/isobus/isobus/isobus_standard_data_description_indices.hpp: Language not supported
- isobus/src/isobus_task_controller_server.cpp: Language not supported
Comments suppressed due to low confidence (1)
scripts/code_gen_ddi_database.py:101
- Ensure that rangeValues has exactly two elements before processing. Add a check to handle cases where the input format changes.
rangeValues = entityLine[2].split(' - ')
9b256c6
to
72d0991
Compare
72d0991
to
89bf4ab
Compare
I wanted to ask before: have you considered pulling in an enum to string converter code like this one: With some smart string humanizer (camelcase to space separeted string converter) code the codes like this one: |
Eh... we don't currently have any external dependencies, and it would be nice to keep it that way |
89bf4ab
to
66d83b5
Compare
Updated branch with force-push, no changes made |
|
Describe your changes
This PR updates the data dictionary file, splits the unit variable into symbol and description, and adds display range variable. With these changes we are able to add two nice formatting methods, see comment below.
Also fixed an issue with seeder example where the reference to
SetpointWorkState
was missing.How has this been tested?
Ran TC with seeder example and it formatted condensed work states:
![image](https://private-user-images.githubusercontent.com/29043784/403873324-a47d652e-8b20-4d0e-99b3-eb446d435918.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MTgxMjksIm5iZiI6MTczODkxNzgyOSwicGF0aCI6Ii8yOTA0Mzc4NC80MDM4NzMzMjQtYTQ3ZDY1MmUtOGIyMC00ZDBlLTk5YjMtZWI0NDZkNDM1OTE4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDA4NDM0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUxYzMxZWFhZDg2Zjk0MjYyMzk3MjVkNjA5NzI2ZjkxZjc1NDA3MWEzNmFiYTNmY2I1Yzg0NWE4MzA2MzhmN2YmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.BHG9tzzg5FINm-ckuL6GpfcFp88QPdKYacLuqmv16dI)