Fix issues with button press on softkey change #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad3154
reviewed
Jan 9, 2025
martonmiklos
force-pushed
the
send_button_and_key_release_on_mask_change
branch
5 times, most recently
from
babf7aa to
15cd3b6
Compare
martonmiklos
force-pushed
the
send_button_and_key_release_on_mask_change
branch
from
e171cd4 to
efd1094
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case if a softkey press triggered a softkey mask change then the button still held messages kept sending forever.
The reason behind this behavior is the following: the button receieved the mouseUp event, added the pressed state to the held buttons list.
The button got removed by the softkeymask change so the mouseRelease event was not called at all on the clicked softkey. However after the actual release of the mouse key the release event for the new button is sent.
The standard says that on softkey mask change the key should send a release event and ignore the key until it released.
The same applies to the buttons on the datamask (on datamask change) but I would like to address that in a separate PR.