Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid return in revoke function #132

Merged
merged 1 commit into from
Jan 4, 2023
Merged

fix: invalid return in revoke function #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions contracts/BaseDocumentStore.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ contract BaseDocumentStore is Initializable {
function _revoke(bytes32 document) internal onlyNotRevoked(document) returns (bool) {
documentRevoked[document] = block.number;
emit DocumentRevoked(document);

return true;
}

function _bulkRevoke(bytes32[] memory documents) internal {
Expand Down
2 changes: 2 additions & 0 deletions contracts/DocumentStoreWithRevokeReasons.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ contract DocumentStoreWithRevokeReasons is DocumentStore {
revoke(document);
revokeReason[document] = reason;
emit DocumentRevokedWithReason(document, reason);

return true;
}

function bulkRevoke(bytes32[] memory documents, uint256 reason) public {
Expand Down