fix: types path issue #99
Conversation
src/index.ts
Outdated
| @@ -36,3 +36,5 @@ export { | |||
| NaivePaymaster__factory as NaivePaymasterFactory, | |||
| UpgradableDocumentStore__factory as UpgradableDocumentStoreFactory, | |||
| } from "./contracts"; | |||
|
|
|||
| export * from "./contracts"; | |||
There was a problem hiding this comment.
Hum is this needed? We have renamed some export, this will lead to some inconsistency
Renaming happened after a breaking change in typechain (just for info), to. avoid a breaking in this library
Maybe there is a way to configure how factories are generated?
There was a problem hiding this comment.
I've tried to checked on this one but it doesn't look like there is a direct way to configure how the factories are being generated.
Did you mean using the default exported names from ./contracts broke something in this library and that was why we renamed the typechain factories before exporting?
There was a problem hiding this comment.
I wrote a little script to automate the manual process of renaming the factories from typechain on build. Hopefully this will resolve the issue with inconsistency. d2881aa
There was a problem hiding this comment.
If this is okay, then I will merge this PR and release the fix today.
There was a problem hiding this comment.
Where is the node script called?
There was a problem hiding this comment.
yup, it's through the post thing.😁
| export { | ||
| DocumentStore__factory as DocumentStoreFactory, | ||
| DocumentStoreCreator__factory as DocumentStoreCreatorFactory, | ||
| GsnCapableDocumentStore__factory as GsnCapableDocumentStoreFactory, | ||
| NaivePaymaster__factory as NaivePaymasterFactory, | ||
| UpgradableDocumentStore__factory as UpgradableDocumentStoreFactory, | ||
| } from "./contracts"; |
There was a problem hiding this comment.
Removed these as they will be renamed and exported automatically on build.
|
🎉 This PR is included in version 2.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
The contract types from typechain aren't built correctly in the path. The contract types are missing and have issues when imported into a Typescript project.
Changes
Bumped target node to v8 from v6Issues
Resolves #97 #98