docs: update readme content #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nebulis
reviewed
Nov 10, 2021
Nebulis
suggested changes
Nov 10, 2021
Nebulis
reviewed
Nov 11, 2021
Nebulis
suggested changes
Nov 11, 2021
| { | ||
| "address": "0xe59877ac86c0310e9ddaeb627f42fdee5f793fbe", | ||
| "minted": true | ||
| { |
There was a problem hiding this comment.
Just to make sure, is this really a valid document that works on ropsten? If that's the case can add that sentence just above? (below you will find a valid document issued on ropsten, etc.)
There was a problem hiding this comment.
yes it is valid and issued on ropsten. Ok I have included the one liner right at the top of it.
README.md
Outdated
| import { getData } from "@govtechsg/open-attestation"; | ||
| import * as document from "./document.json"; | ||
|
|
||
| const customVerifier = { |
There was a problem hiding this comment.
ok, have added the Verifier type
ryanseee
force-pushed
the
docs/update-readme
branch
from
d5ed179 to
3446030
Compare
Nebulis
approved these changes
Nov 16, 2021
|
🎉 This PR is included in version 7.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.