Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: oa-verify v4 (alpha) #259

Merged
merged 8 commits into from
Sep 7, 2023
Merged

feat: oa-verify v4 (alpha) #259

merged 8 commits into from
Sep 7, 2023

Conversation

HJunyuan
Copy link
Member

@HJunyuan HJunyuan commented Aug 31, 2023 •
edited
Loading

What does this PR do?

  • chore: upgrade to node 18
  • ci: create alpha release based on alpha branch
  • feat: introduce oa-verify v4 (alpha) to verify VCs that are signed with DIDs
    • Document Integrity
    • Document Status
    • Issuer Identity

Caveat

  • Verification of documents issued onto the document store are not available yet - on hold as not crucial at the moment
  • Tests are still WIP

Todo

@HJunyuan
Copy link
Member Author

FYI build is currently failing as @govtechsg/open-attestation needs to be bumped first

@HJunyuan HJunyuan changed the base branch from master to alpha August 31, 2023 08:27
cavacado
cavacado reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@cavacado cavacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine, seems like many of the file changes are prettier errors.

why are the tests wip though, needs the oa pr to go in first?

package.json Outdated
"prerelease": true
}
]
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to the prev comments

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will move this to it's own .releaserc file

src/common/errorHandler.ts
}
}
};
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: no idea why we used X as the 2nd generic type, its usually T, U
no action needed

package.json Outdated
@@ -27,7 +27,7 @@
"dependencies": {
"@govtechsg/dnsprove": "^2.6.1",
"@govtechsg/document-store": "^2.2.3",
"@govtechsg/open-attestation": "^6.2.0",
"@govtechsg/open-attestation": "../open-attestation",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know of npm link?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is temporary. We will change it to the alpha version once it's merged and published

@HJunyuan
Copy link
Member Author

HJunyuan commented Sep 6, 2023

seems like many of the file changes are prettier errors.

To see the changes without the lint fixes: https://github.com/Open-Attestation/oa-verify/pull/259/files/d2ecc625b925549989bb72fa7583ea05c030e5d8

why are the tests wip though, needs the oa pr to go in first?

To save time, the first alpha release will not include a majority of tests. Same for the open-attestation repo. We can work on them in the subsequent alpha versions

cavacado
cavacado approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@cavacado cavacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as the other one

@HJunyuan HJunyuan merged commit a2fb2be into alpha Sep 7, 2023
5 checks passed
@HJunyuan HJunyuan deleted the feat/oa-v4-alpha branch September 7, 2023 03:59
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

🎉 This PR is included in version 8.3.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

cavacado pushed a commit to TradeTrust/tt-verify that referenced this pull request Nov 10, 2023
@HJunyuan @cavacado
feat: oa-verify v4 (alpha) (Open-Attestation#259)
f270553 
* chore: upgrade to node 18

* ci: prepare alpha release

* feat: oa v4 alpha

* fix: lint errors

* test: update fixtures

* chore: separate .releaserc file

* chore: bump open-attestation to 6.8.0-alpha.1

* test: update snapshots based on new response by infura
cavacado pushed a commit to TradeTrust/tt-verify that referenced this pull request Nov 10, 2023
@HJunyuan @cavacado
feat: oa-verify v4 (alpha) (Open-Attestation#259)
fe69a13 
* chore: upgrade to node 18

* ci: prepare alpha release

* feat: oa v4 alpha

* fix: lint errors

* test: update fixtures

* chore: separate .releaserc file

* chore: bump open-attestation to 6.8.0-alpha.1

* test: update snapshots based on new response by infura
cavacado added a commit to TradeTrust/tt-verify that referenced this pull request Nov 10, 2023
@cavacado @HJunyuan
feat: rebase alpha to track master (#5)
fd3077e 
* fix: expose verify signature (Open-Attestation#261)

* feat: init release, change namespace (#1)

* feat: ci/cd (#3)

* feat: ci/cd (#4)

* feat: oa-verify v4 (alpha) (Open-Attestation#259)

* chore: upgrade to node 18

* ci: prepare alpha release

* feat: oa v4 alpha

* fix: lint errors

* test: update fixtures

* chore: separate .releaserc file

* chore: bump open-attestation to 6.8.0-alpha.1

* test: update snapshots based on new response by infura

---------

Co-authored-by: Kyle Huang Junyuan <kyle@hjunyuan.com>
@john-dot-oa john-dot-oa mentioned this pull request Nov 29, 2023
Open
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 9.3.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

HJunyuan added a commit that referenced this pull request May 23, 2024
@HJunyuan
feat: v4 beta release (#288)
02af0e0 
* feat: oa-verify v4 (alpha) (#259)

* chore: upgrade to node 18

* ci: prepare alpha release

* feat: oa v4 alpha

* fix: lint errors

* test: update fixtures

* chore: separate .releaserc file

* chore: bump open-attestation to 6.8.0-alpha.1

* test: update snapshots based on new response by infura

* fix: align according to new oa v4 (beta) types

* chore: upgrade jest from v26 to v27

* chore: bump open-attestation to latest beta

* test: update v4 fixtures
HJunyuan added a commit that referenced this pull request Jun 14, 2024
@HJunyuan
feat: v4 beta release (#288)
e445b4b 
* feat: oa-verify v4 (alpha) (#259)

* chore: upgrade to node 18

* ci: prepare alpha release

* feat: oa v4 alpha

* fix: lint errors

* test: update fixtures

* chore: separate .releaserc file

* chore: bump open-attestation to 6.8.0-alpha.1

* test: update snapshots based on new response by infura

* fix: align according to new oa v4 (beta) types

* chore: upgrade jest from v26 to v27

* chore: bump open-attestation to latest beta

* test: update v4 fixtures
@yanlow yanlow mentioned this pull request Sep 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@cavacado cavacado cavacado approved these changes

Assignees
No one assigned
Labels
released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HJunyuan @cavacado