feat: add verifyWithIndividualChecks #72
Conversation
sebastianquek
force-pushed
the
feat/verifyWithIndividualChecks
branch
2 times, most recently
from
c5587e8 to
a44da8d
Compare
sebastianquek
force-pushed
the
feat/verifyWithIndividualChecks
branch
from
a44da8d to
8ebd647
Compare
src/verify.test.ts
Outdated
| @@ -61,3 +63,56 @@ describe("verify", () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe("verifyWithIndividualChecks", () => { | |||
There was a problem hiding this comment.
what does this test bring compare to integration test ?
There was a problem hiding this comment.
The integration test ensures the checks work on an actual document with the correct network specified (also ensures the various checks work properly together).
The unit test, on the other hand, mocks what's returned by the various checks and checks whether the returned values are correct given these mocks. Also, we can mimic the way the various promises resolve at different times.
How should we better spilt the test concerns?
There was a problem hiding this comment.
As discussed, I've removed the unit tests that don't value add much.
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Returns an array of promises, each promise corresponds to a verification check.
The last promise resolves to the overall validity based on all the checks.
This allows us to work on the promises independently from the other verification checks.