-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: revocation by document hash #1
Conversation
serverless create -t aws-nodejs-typescript
This reverts commit e58fbab.
…p-responder into feat/revoke-by-hash
src/functions/insert/handler.ts
Outdated
|
||
import schema from "./schema"; | ||
|
||
const REASON_CODES = [...Array(11).keys()]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clever, but reads poorly, could you wrap it around a generate range function and put it in utils?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly, will change it to:
const REASON_CODES = [...Array(11).keys()]; | |
const REASON_CODES = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 lgtm lets go
Context
What does this PR do?
->documentId
documentHash
revoked = true / false
,success = true / false
, etc.npm run dev
npm run deploy
(i.e.sls deploy
)