chore: use ajv standalone validation code #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HJunyuan
reviewed
Oct 26, 2023
src/shared/ajv.ts
Outdated
| if (!schema) throw new Error(`Could not find ${key} schema`); | ||
| return schema; | ||
| return schema as AnyValidateFunction; |
There was a problem hiding this comment.
What is the difference between AnyValidateFunction vs ValidateFunction?
There was a problem hiding this comment.
Oh AnyValidateFunction caters for async validations. Just realised we dont use it in our validation, Ill revert to using ValidateFunction like before!
HJunyuan
approved these changes
Oct 27, 2023
|
🎉 This PR is included in version 6.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
zixiang2018
added a commit
that referenced
this pull request
Oct 27, 2023
This reverts commit 2a69683.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
unsafe-evalin their Content Security Policy (CSP) to use our library because we are using ajv compile at runtime. To have a more secure CSP, we will be compiling the schemas at build time instead.What this PR does
strictandnon-strict; hence there are two compiled javascript functions file which caters for both scenarios.unsafe-evalon Verifiers UItsconfig.jsontoallowJsimports (to import the compiled files)