Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Wip/oa v4 types #276

Merged
merged 43 commits into from
Apr 26, 2024
Merged

chore: Wip/oa v4 types #276

merged 43 commits into from
Apr 26, 2024

Conversation

phanshiyu
Copy link
Contributor

typing fixes and refactors

HJunyuan and others added 30 commits April 24, 2024 16:20
@HJunyuan
wip: oa v4 types
d3aafc2
@phanshiyu
refactor: prefer string union
b102ee9
@phanshiyu
refactor: reference constant tuple instead
e693b92
@phanshiyu
refactor: finalTypes follows pattern of finalContexts
c4c91fe
@phanshiyu
refactor: document -> raw document for clarity
5ff08a3
@phanshiyu
fix: rawDocument should not be used directly for digest and salting
23af438
@phanshiyu
fix: remove asserting to string to let the literal infer properly
5cc50cf
@phanshiyu
fix: typings
e7e4c72
@phanshiyu
refactor: move assertion earlier
27e6e8e
@phanshiyu
refactor: assert oa vc than try vc
2bc4066
@phanshiyu
fix: refer to new oa vc type in digest and verify
5fa7561
@phanshiyu
fix: refer to new oa vc typings
9ce1255
@phanshiyu
fix: refer to new oa vc typings
e6bff07
@phanshiyu
fix: refer to new oa vc typings
a259eac
@phanshiyu
refactor: improve naming consistency
8dfd6af
@phanshiyu
fix: typing, should be looser
9fce84a
@phanshiyu
fix: a union b does not override a props with b props
d409c68
@phanshiyu
fix: added assertion type to prevent accident extension to base type
e30c8e8
@phanshiyu
refactor: wording
194f19e
@phanshiyu
refactor: better readability for wrapped types
cd34a7d
@phanshiyu
refactor: move things within file and some renaming
d3baf69
@phanshiyu
refactor: improve naming of variables
3bdc13e
@phanshiyu
fix: use new typings
db12f50
@phanshiyu
fix: passthroughs needed to allow extension, added name and render me…
22df165 
…thod so they dont get stripped
@phanshiyu
test: added a guard test which is currently failing
fc0ce61
@phanshiyu
refactor: merged data model with types and renamed VC type
8f42178
@phanshiyu
refactor: improve helper fn naming
3187237
@phanshiyu
fix: use extend instead of and since it results in dup errors, remove…
0f3d311 
… hex validation since these props are generated by us, allow passthrough for wrap proof so that a signed wrap can pass a wrap only validation test
@phanshiyu
test: update snapshot
3c40ebc
@phanshiyu
fix: was using the wrong document for the check
946ae63
HJunyuan
HJunyuan reviewed Apr 26, 2024
View reviewed changes
@phanshiyu phanshiyu changed the title Wip/oa v4 types chore: Wip/oa v4 types Apr 26, 2024
@phanshiyu phanshiyu merged commit 2c45f54 into oa-v4 Apr 26, 2024
5 of 6 checks passed
@phanshiyu phanshiyu deleted the wip/oa-v4-types branch April 26, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HJunyuan HJunyuan HJunyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phanshiyu @HJunyuan