Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ws security advisory from ethers v5 #308

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

phanshiyu
Copy link
Contributor

Summary

What is the background of this pull request?
use ether v5 submodules to resolve GHSA-3h5v-q93c-6h6q

Changes

  • What are the changes made in this pull request?
  • Change this and that, etc...
  1. Use only sub modules we need from ethers v5, which does not have the ws dependency that is linked to the above mentioned advisory.

Issues

What are the related issues or stories?

@phanshiyu phanshiyu requested a review from HJunyuan July 23, 2024 03:09
@phanshiyu phanshiyu changed the title chore: use only what we need from v5 ethers fix: ws security advisory from ethers v5 Jul 23, 2024
Copy link
Member

@HJunyuan HJunyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@phanshiyu phanshiyu merged commit 239bdba into master Jul 23, 2024
6 checks passed
@phanshiyu phanshiyu deleted the chore/use-ethers-v5-sub-modules branch July 23, 2024 03:14
Copy link

🎉 This PR is included in version 6.9.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants