-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add identity-vc context for tradetrust #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats the main difference between this alpha context and the one done by Kyle?
First off, the name space is different from oacred
to ttcred
since this is fork in the road for definitions
As such, all the OpenAttesation names have been renamed to TradeTrust.
While @HJunyuan was developing v4, he omitted certain non-standard properties from a vanilla VC such as network
and attachments
but for tt's use case, these are important so I have added them back.
Lastly, due to the introduction of identityVC
verification method exclusive only to tt, this has to be added into the context so that our wrapping algorithm knows how to process it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats different from this file as compared to the one in OA?
Mainly more defiintiions so that we reference them instead of duplicating them in the schema itself.
The key change is the addition of the optional identityVC
inside of the issuer.identity
field, which would be critical in the idvc solution for tradetrust.
A sample of a file with the IDVC embedded into the TT file for some visualisation |
🎉 This PR is included in version 1.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Tradetrust is embarking on a pilot that requires a new context document to be added to a typical oa-document.
This is to ensure that the wrapping functionality still works for the new document type. (even though we will be moving away from the main trunk of open-attestation)
Here, the context just indicates that the value is only a json literal, and does not participate in the expansion for the context.
Ideally, we should fork this schemata repo and reduce the documents to tradetrust specific documents and that could be a future action for whoever is taking over tradetrust.
Heres a JSON-LD playground example that demonstrates the combined vc
https://tinyurl.com/5bwdh8sj