Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactor #1586

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Minor refactor #1586

wants to merge 1 commit into from

Conversation

Deixx
Copy link
Contributor

@Deixx Deixx commented Nov 18, 2024

Rename get_core_devices() to get_cores()
Removed hardcoded / in conftest for paths which can be resolved differently depending on OS

Resolves #1544

katlapinka
katlapinka previously approved these changes Nov 25, 2024
katlapinka
katlapinka previously approved these changes Nov 27, 2024
Kamoppl
Kamoppl previously approved these changes Dec 11, 2024
@Deixx Deixx dismissed stale reviews from Kamoppl and katlapinka via b669392 January 20, 2025 09:58
@Deixx Deixx force-pushed the get-cores branch 2 times, most recently from b669392 to 0930299 Compare January 20, 2025 10:00
Rename get_core_devices() to get_cores()
Removed hardcoded / in conftest for paths which can be
resolved differently depending on OS

Signed-off-by: Daniel Madej <daniel.madej@huawei.com>
@Deixx Deixx marked this pull request as draft January 20, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Cache.get_core_devices() to get_cores()
3 participants