Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Read set files only on -S,--context-set option #113

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Fix: Read set files only on -S,--context-set option #113

merged 2 commits into from
Nov 13, 2023

Conversation

soumeh01
Copy link
Collaborator

No description provided.

Copy link
Contributor

Test Results

    4 files  ±  0    36 suites  ±0   3s ⏱️ ±0s
158 tests +  4  158 ✔️ +  4  0 💤 ±0  0 ±0 
632 runs  +16  632 ✔️ +16  0 💤 ±0  0 ±0 

Results for commit a623868. ± Comparison against base commit c2765e5.

This pull request removes 2 and adds 6 tests. Note that renamed tests count towards both.
cbuild/pkg/builder/csolution ‑ TestGetSelectedContexts/test_get_cprj_file_path
cbuild/pkg/builder/csolution ‑ TestGetSelectedContexts/test_set_file_missing
cbuild/pkg/builder/csolution ‑ TestGetCbuildSetFilePath
cbuild/pkg/builder/csolution ‑ TestGetCbuildSetFilePath/test_get_cbuild-set_file_path
cbuild/pkg/builder/csolution ‑ TestGetCbuildSetFilePath/test_invalid_input_file
cbuild/pkg/builder/csolution ‑ TestGetSelectedContexts/test_get_contexts_from_idx_file
cbuild/pkg/builder/csolution ‑ TestGetSelectedContexts/test_get_contexts_from_set_file
cbuild/pkg/builder/csolution ‑ TestGetSelectedContexts/test_with_missing_set_file

Copy link

codeclimate bot commented Nov 13, 2023

Code Climate has analyzed commit a623868 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 93.5% (80% is the threshold).

This pull request will bring the total coverage in the repository to 81.7% (3.6% change).

View more on Code Climate.

@soumeh01 soumeh01 requested a review from brondani November 13, 2023 10:09
Copy link
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soumeh01 soumeh01 merged commit af854a1 into main Nov 13, 2023
13 checks passed
@soumeh01 soumeh01 deleted the bug_fix branch November 13, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants