Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message cleanup and Return same exit code as of orchestrated exe #234

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

soumeh01
Copy link
Collaborator

@soumeh01 soumeh01 commented Jun 12, 2024

The change addresses 2 issues:

  • The error message error generating build files by cbuild is redundant. cbuild should return the same error which are reported by csolution covert step.
  • cbuild should return the same exit code provided by the orchestrated utlities.

Copy link
Contributor

github-actions bot commented Jun 12, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

github-actions bot commented Jun 12, 2024

Test Results

  4 files  ±0   44 suites  ±0   6s ⏱️ -1s
201 tests ±0  201 ✅ ±0  0 💤 ±0  0 ❌ ±0 
804 runs  ±0  804 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e918190. ± Comparison against base commit 02cc686.

♻️ This comment has been updated with latest results.

Copy link

codeclimate bot commented Jun 12, 2024

Code Climate has analyzed commit e918190 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 78.8% (0.0% change).

View more on Code Climate.

@soumeh01 soumeh01 requested a review from brondani June 12, 2024 08:02
Copy link
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soumeh01 soumeh01 merged commit e334a0c into main Jun 12, 2024
16 checks passed
@soumeh01 soumeh01 deleted the cleanup branch June 12, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants