Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rebuild handling #347

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix rebuild handling #347

merged 1 commit into from
Dec 9, 2024

Conversation

brondani
Copy link
Collaborator

@brondani brondani commented Dec 6, 2024

Fixes

Changes

Checklist

  • 🤖 This change is covered by unit tests as required.
  • 🤹 All required manual testing has been performed.
  • 🛡️ Security impacts have been considered.
  • 📖 All documentation updates are complete.
  • 🧠 This change does not change third-party dependencies

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Test Results

  4 files  ±0   52 suites  ±0   5s ⏱️ -2s
236 tests ±0  236 ✅ ±0  0 💤 ±0  0 ❌ ±0 
944 runs  ±0  944 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e9d5019. ± Comparison against base commit bb2768d.

Copy link

codeclimate bot commented Dec 6, 2024

Code Climate has analyzed commit e9d5019 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 27.2% (50% is the threshold).

This pull request will bring the total coverage in the repository to 71.3% (-0.6% change).

View more on Code Climate.

@brondani brondani marked this pull request as ready for review December 6, 2024 13:01
@brondani brondani requested a review from jkrech December 6, 2024 13:01
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brondani brondani merged commit aa67238 into main Dec 9, 2024
15 of 16 checks passed
@brondani brondani deleted the fix-rebuild-handling branch December 9, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants