Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpackget] --concurrent-downloads (default 5) corrupts downloaded *.pdsc files #197 #200

Merged
merged 18 commits into from
Sep 1, 2023

Conversation

thorstendb-ARM
Copy link
Collaborator

@thorstendb-ARM thorstendb-ARM commented Aug 29, 2023

fixed:

  • concurrent download scheduler
  • added tests on downloaded files

…dsc files #197

fixed:
- concurrent download scheduler
- added tests on downloaded files
@thorstendb-ARM thorstendb-ARM changed the title [cpackget] --concurrent-downloads (default 5) corrupts downloaded *.p… [cpackget] --concurrent-downloads (default 5) corrupts downloaded *.pdsc files #197 Aug 29, 2023
@thorstendb-ARM thorstendb-ARM marked this pull request as ready for review August 29, 2023 15:15
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Patch coverage is 66.15% of modified lines.

Files Changed Coverage
cmd/installer/root.go 65.62%
cmd/commands/root.go 100.00%

📢 Thoughts on this report? Let us know!.

- concurrent part on "update-index"
  root.go (installer) UpdateInstalledPDSCFiles()
@thorstendb-ARM thorstendb-ARM requested a review from bgn42 August 31, 2023 14:44
cmd/installer/root.go Outdated Show resolved Hide resolved
bgn42
bgn42 previously approved these changes Aug 31, 2023
Copy link
Collaborator

@bgn42 bgn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a minor superfluous condition.

- set code coverage to 84%
@thorstendb-ARM thorstendb-ARM merged commit 7e85ad8 into main Sep 1, 2023
@thorstendb-ARM thorstendb-ARM deleted the cpackget#197 branch September 1, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants