[packchk] Rework Message M396

- M396 to ERROR
- no check for ascending date anymore
- added case to test data

Co-authored-by: Thorsten de Buhr <thorstendb-ARM@users.noreply.github.com>

tools/packchk/src/PackChk_Msgs.cpp

@@ -205,7 +205,7 @@ const MsgTable PackChk::msgTable = {
   { "M393", { MsgLevel::LEVEL_WARNING3, CRLF_B, "Package has development version '%DEVVERSION%': '%RELEASEVER%'" } },
   { "M394", { MsgLevel::LEVEL_ERROR,    CRLF_B, "Not Semantic Versioning, ignoring version: '%RELEASEVER%'" } },
   { "M395", { MsgLevel::LEVEL_WARNING3, CRLF_B, "Release date attribute is not set for release version: '%RELEASEVER%'" } },
-  { "M396", { MsgLevel::LEVEL_WARNING,  CRLF_B, "Release %TAG% not consecutive (newest first): '%RELEASEVER%', '%RELEASEDATE%' (prev.: '%LATESTVER%', '%LATESTDATE%', see Line %LINE%)" } },
+  { "M396", { MsgLevel::LEVEL_ERROR,    CRLF_B, "Release %TAG% not consecutive (newest first): '%RELEASEVER%', '%RELEASEDATE%' (prev.: '%LATESTVER%', '%LATESTDATE%', see Line %LINE%)" } },
   { "M397", { MsgLevel::LEVEL_WARNING,  CRLF_B, "File extension '.pdsc' must be lowercase: '%PATH%'" } },
   { "M398", { MsgLevel::LEVEL_ERROR,    CRLF_B, "Attribute 'Dname' missing in expression using 'Pname=\"%NAME%\"" } },
   { "M399", { MsgLevel::LEVEL_WARNING3, CRLF_B, "Attribute '%TAG%' is ignored, because '%TAG2%' + '%TAG3%' is specified" } },

tools/packchk/src/ValidateSyntax.cpp

@@ -391,13 +391,6 @@ bool ValidateSyntax::CheckPackageReleaseDate(RtePackage* pKg)
       }
     }
 
-    if(!latestDate.empty() && !releaseDate.empty()) {
-      int res = AlnumCmp::Compare(latestDate, releaseDate);     // sorting of release version is fixed. The latest version is at the top the earliest release tag is at the bottom
-      if(res < 0) {   // allow same date
-        LogMsg("M396", TAG("Date"), RELEASEVER(releaseVersion), RELEASEDATE(releaseDate), LATESTVER(latestVersion), LATESTDATE(latestDate), LINE(latestLineNo), lineNo);
-      }
-    }
-
     latestVersion = releaseVersion;
     latestDate = releaseDate;
     latestLineNo = lineNo;

tools/packchk/test/data/SemVerTest/Arm.SemVerTest_DFP.pdsc

@@ -15,6 +15,9 @@
       OK: Same date different Version
     </release>
 
+    <release version="4.6.3" date="2023-01-01">
+      Patch with newer date is allowed, versions must be in order.
+    </release>
     <release version="4.6.2" date="2021-03-16">
       <!-- ERROR M329: Description not set for Release Information '4.6.2' -->
     </release>