issue253 Use extend with overlap with retile in vectorize #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdries
requested changes
Jan 2, 2025
| @@ -617,13 +617,19 @@ class OpenEOProcesses extends Serializable { | |||
| val maxExtent = datacube.metadata.extent | |||
| //naive approach: combine tiles and hope that we don't exceed the max size | |||
| //if we exceed the max, vectorize will run on separate tiles, and we'll need to merge results | |||
| val newCols = Math.min(256*20,layout.cols) | |||
| val newRows = Math.min(256*20,layout.rows) | |||
| val newCols = Math.min(256,layout.cols) | |||
There was a problem hiding this comment.
Here I suggest to still work with a larger tile size by default, maybe 256*4, avoiding that we make an immediate change from very coarse tiling to small tiles.
It is always possible that certain edge cases were not detected in our testing, and by doing it like this we do a more gradual rollout.
It is however important to ensure that the unit test also continues to work on the more complex case. Making this tile size configurable would be one way to achieve that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#253