Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[load_stac] allow load from static Collection #203

Closed
wants to merge 2 commits into from

Conversation

clausmichele
Copy link
Member

Allow to use load_stac with a static STAC Collection. It will be necessary for the test suite, since we plan to host the STAC Collection on GitHub (no API).

You can test it with the one I prepared:

from openeo.local import LocalConnection
local_conn = LocalConnection("./")

url = "https://raw.githubusercontent.com/clausmichele/openeo-test-suite/eurac_process_graphs/src/openeo_test_suite/data/SENTINEL2_L2A_SAMPLE/SENTINEL2_L2A_SAMPLE.json"
bands = ["B04"]

s2_cube = local_conn.load_stac(url=url,
   bands=bands,
)
s2_cube.execute()

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (8d9e3fb) 79.42% compared to head (3ed5d80) 78.38%.

Files Patch % Lines
...ocesses_dask/process_implementations/cubes/load.py 8.33% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   79.42%   78.38%   -1.04%     
==========================================
  Files          30       30              
  Lines        1468     1490      +22     
==========================================
+ Hits         1166     1168       +2     
- Misses        302      322      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clausmichele
Copy link
Member Author

clausmichele commented Dec 13, 2023

I need to clarify if the self-contained STAC Collection is actually valid (currently a valid STAC but I can't find any other examples doing something like this), I will re open the PR once clarified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant