Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove binary versions of processes? #258

Closed
m-mohr opened this issue May 31, 2021 · 0 comments · Fixed by #259 or #261
Closed

Remove binary versions of processes? #258

m-mohr opened this issue May 31, 2021 · 0 comments · Fixed by #259 or #261
Labels
help wanted Extra attention is needed question Further information is requested
Milestone

Comments

@m-mohr
Copy link
Member

m-mohr commented May 31, 2021

We seem to conclude that having a process reduce_spatial(raster-cube, process, context) -> raster-cube is the way to go. [...]

One thing that came to mind is that for aggregate_spatial and reduce_dimension we have the binary variants (e.g. reduce_dimension_binary). We'd need a binary variant also for reduce_spatial, but on the other hand, I'm wondering whether we should remove these binary variants for now? There's no implementation yet and I've also not heard that anyone is actually planning to implement one of them.

Originally posted by @m-mohr in #226 (comment)

They were experimental before, so we can easily remove them without breaking change.

@m-mohr m-mohr added this to the 1.1.0 milestone May 31, 2021
m-mohr added a commit that referenced this issue May 31, 2021
@m-mohr m-mohr linked a pull request May 31, 2021 that will close this issue
@m-mohr m-mohr added help wanted Extra attention is needed question Further information is requested labels May 31, 2021
@m-mohr m-mohr linked a pull request May 31, 2021 that will close this issue
@m-mohr m-mohr changed the title Reduce binary versions of processes? Remove binary versions of processes? Jun 1, 2021
m-mohr added a commit that referenced this issue Jun 1, 2021
@m-mohr m-mohr closed this as completed Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
1 participant