Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow creation of empty bands array in load_collection (and other places) #372

Closed
dthiex opened this issue Jun 6, 2022 · 1 comment
Assignees
Milestone

Comments

@dthiex
Copy link
Contributor

dthiex commented Jun 6, 2022

Currently it's possible to created bands: [] with the editor resulting into a not valid PG being send to the backend.

I think it either shouldn't be allowed to construct an empty array with the editor or set it to null in such a case.

@m-mohr
Copy link
Member

m-mohr commented Jun 6, 2022

Strictly speaking, an empty bands array is allowed/valid in load_collection, the schema doesn't set minItems to 1:
https://github.com/Open-EO/openeo-processes/blob/draft/load_collection.json#L164
So I'm moving this over to openeo-processes so that we can fix it there. Once minItems is set to 1, the Editor should handle it correctly (but I'll verify it after fixing it here).

@m-mohr m-mohr transferred this issue from Open-EO/openeo-web-editor Jun 6, 2022
@m-mohr m-mohr self-assigned this Jun 6, 2022
@m-mohr m-mohr added the bug label Jun 6, 2022
@m-mohr m-mohr added this to the 1.3.0 milestone Jun 6, 2022
@m-mohr m-mohr added the patch label Jun 6, 2022
@m-mohr m-mohr changed the title Don't allow creation of empty bands object with editor in load collection process Don't allow creation of empty bands array in load_collection (and other places) Jun 27, 2022
m-mohr added a commit that referenced this issue Jul 19, 2022
@m-mohr m-mohr closed this as completed Jul 19, 2022
@m-mohr m-mohr modified the milestones: 1.3.0, 2.0.0 Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants