Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply_polygon: rename polygons parameter to geometries #511

Closed
soxofaan opened this issue Jun 7, 2024 · 3 comments · Fixed by #518
Closed

apply_polygon: rename polygons parameter to geometries #511

soxofaan opened this issue Jun 7, 2024 · 3 comments · Fixed by #518

Comments

@soxofaan
Copy link
Member

soxofaan commented Jun 7, 2024

apply_polygons has a polygons argument:

"name": "polygons",
"description": "A vector data cube containing at least one polygon. The provided vector data can be one of the following:\n\n* A `Polygon` or `MultiPolygon` geometry,\n* a `Feature` with a `Polygon` or `MultiPolygon` geometry, or\n* a `FeatureCollection` containing at least one `Feature` with `Polygon` or `MultiPolygon` geometries.\n* Empty geometries are ignored.",

This is not in line with comparable processes that use geometries for the same concept, like aggregate_spatial, filter_spatial, filter_vector, vector_buffer. Note that mask_polygon also doesn't use polygons.

It also appears to be confusing users about how MultiPolygons are supported

@m-mohr
Copy link
Member

m-mohr commented Jun 16, 2024

Fine for me, would be breaking though. So is it also fine for VITO to have a breaking change here?

@soxofaan soxofaan changed the title apply_polygons: rename polygons parameter to geometries apply_polygon: rename polygons parameter to geometries Jul 17, 2024
soxofaan added a commit to Open-EO/openeo-python-driver that referenced this issue Jul 17, 2024
@soxofaan
Copy link
Member Author

with Open-EO/openeo-python-driver@15b72a7 VITO implementation will support both geometries (preferred) and polygons (legacy)

@m-mohr
Copy link
Member

m-mohr commented Jul 17, 2024

Would you mind creating a PR for this in openeo-processes? @soxofaan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants