-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply_polygon
: rename polygons
parameter to geometries
#511
Comments
Fine for me, would be breaking though. So is it also fine for VITO to have a breaking change here? |
soxofaan
changed the title
Jul 17, 2024
apply_polygons
: rename polygons
parameter to geometries
apply_polygon
: rename polygons
parameter to geometries
soxofaan
added a commit
to Open-EO/openeo-python-driver
that referenced
this issue
Jul 17, 2024
But still support legacy `polygons` for now refs: Open-EO/openeo-processes#511, #288
with Open-EO/openeo-python-driver@15b72a7 VITO implementation will support both |
Would you mind creating a PR for this in openeo-processes? @soxofaan |
soxofaan
added a commit
to soxofaan/openeo-processes
that referenced
this issue
Jul 18, 2024
This was referenced Jul 18, 2024
m-mohr
pushed a commit
that referenced
this issue
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
apply_polygons
has apolygons
argument:openeo-processes/proposals/apply_polygon.json
Lines 19 to 20 in 965bbae
This is not in line with comparable processes that use
geometries
for the same concept, likeaggregate_spatial
,filter_spatial
,filter_vector
,vector_buffer
. Note thatmask_polygon
also doesn't usepolygons
.It also appears to be confusing users about how MultiPolygons are supported
The text was updated successfully, but these errors were encountered: