-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run_udf(_externally): don't mention raster-cube in the schemas #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine to me,
just a minor note
proposals/run_udf_externally.json
Outdated
"description": "Any data type." | ||
} | ||
] | ||
"description": "The data processed by the UDF. The returned value can be of any data type and is exactly what the UDF code returns.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The returned value can be of any data type and is exactly what the UDF code returns.
Is that true? Are there any backends that support returning anything else than a Raster?
Especially interesting when transmitting "trained model objects" back and forth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether I agree here, but this indeed should be phrased more carefully as we indeed also thing about "helper" signatures that users can implement, which would return something different... Hard to document this properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"description": "The data processed by the UDF. The returned value can be of any data type and is exactly what the UDF code returns.", | |
"description": "The data processed by the UDF. The returned value can in principle be of any data type, but it depends on what is returned by the UDF code. Please see the implemented UDF interface for details.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UDF interface here refers to the "UDF signature" implemented as there are a couple of helpers that make analysis easier for the user, but influence what is returned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've commented directly. Generally also like this approach!
See issue #285 for context.
This was discussed today with some of you already and this is the resulting PR.