Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raster to vector Conversion #434

Open
wants to merge 17 commits into
base: draft
Choose a base branch
from
Open

Raster to vector Conversion #434

wants to merge 17 commits into from

Conversation

PondiB
Copy link
Member

@PondiB PondiB commented Apr 25, 2023 •
edited
Loading

closes issue #155

An optional "projection" parameter has been inspired by the Rasterio function and GEE. Not sure if we should keep it.

@PondiB PondiB requested review from soxofaan and m-mohr April 25, 2023 09:47
@PondiB
Copy link
Member Author

PondiB commented Apr 25, 2023

FYI; I'll try and figure out what causes the failures.

@m-mohr
Copy link
Member

m-mohr commented Apr 25, 2023

@PondiB experimental: true is missing, remove dot at the end of summary and a spellcheck issue :-)

@PondiB
Copy link
Member Author

PondiB commented Apr 25, 2023

@PondiB experimental: true is missing, remove dot at the end of summary and a spellcheck issue :-)

Aha, awesome, thanks @m-mohr

soxofaan
soxofaan reviewed Apr 26, 2023
View reviewed changes
Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial comments

proposals/raster_to_vector.json Outdated Show resolved Hide resolved
proposals/raster_to_vector.json Outdated Show resolved Hide resolved
proposals/raster_to_vector.json Outdated Show resolved Hide resolved
proposals/raster_to_vector.json Outdated Show resolved Hide resolved
proposals/raster_to_vector.json Show resolved Hide resolved
PondiB and others added 3 commits April 28, 2023 14:51
@PondiB @soxofaan
Update proposals/raster_to_vector.json
1b51f58 
Co-authored-by: Stefaan Lippens <soxofaan@users.noreply.github.com>
@PondiB
update returns description
bb4695f
@PondiB
update descriptions
6d4bdec
@m-mohr m-mohr added this to the 2.1.0 milestone Apr 29, 2023
m-mohr
m-mohr requested changes Sep 30, 2023
View reviewed changes
Copy link
Member

@m-mohr m-mohr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be testable, this needs more specific information about how the conversion is done. See comments above.

PondiB and others added 2 commits December 13, 2023 22:29
@PondiB @m-mohr
Update proposals/raster_to_vector.json
1ef7199 
Co-authored-by: Matthias Mohr <m.mohr@uni-muenster.de>
@PondiB
clear description
47a70fc
@PondiB
Copy link
Member Author

PondiB commented Dec 14, 2023

To be testable, this needs more specific information about how the conversion is done. See comments above.

Factored that in.

@PondiB PondiB closed this Dec 14, 2023
@PondiB PondiB reopened this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soxofaan soxofaan soxofaan left review comments

@m-mohr m-mohr m-mohr requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
new process vector
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@PondiB @m-mohr @soxofaan