Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement lazy if branching #109

Closed
soxofaan opened this issue Mar 24, 2022 · 1 comment
Closed

implement lazy if branching #109

soxofaan opened this issue Mar 24, 2022 · 1 comment
Assignees
Labels

Comments

@soxofaan
Copy link
Member

soxofaan commented Mar 24, 2022

see:

The if process should not blindly evaluate both the accept and reject value, but only the branch that is necessary.

This has now come up in a use case where user does something like this:

S1bands = if_(
  eq(s1_collection, "SENTINEL1_GRD"),
  S1bands.sar_backscatter().apply(lambda x: 10 * x.log(base=10)),
  S1bands.apply(lambda x: 10 * x.log(base=10))
)

With s1_collection == "S1_GRD_SIGMA0", the sar_backscatter process should not be applied, but I still get this error:
[400] Internal: Process "sar_backscatter" is not applicable for collection S1_GRD_SIGMA0_ASCENDING. (ref: 0817481a-7141-44e5-ac0a-1bcde5bcce3a)
And with s1_collection == "SENTINEL1_GRD", I get an error for no spatial filter. But the spatial filter is specified.
[400] MissingSpatialFilter: No spatial filter could be derived to load this collection: SENTINEL1_GRD . Please specify a bounding box, or polygons to define your area of interest. (ref: 0f888861-9cf5-4dce-876f-b43b6312169c)

@jdries jdries assigned jdries and unassigned soxofaan Feb 7, 2023
jdries added a commit that referenced this issue Feb 7, 2023
jdries added a commit to Open-EO/openeo-geopyspark-driver that referenced this issue Feb 7, 2023
@jdries
Copy link
Contributor

jdries commented Feb 8, 2023

is deployed

@jdries jdries closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants