Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong default align in resample_spatial #355

Closed
soxofaan opened this issue Jan 20, 2025 · 1 comment
Closed

wrong default align in resample_spatial #355

soxofaan opened this issue Jan 20, 2025 · 1 comment

Comments

@soxofaan
Copy link
Member

soxofaan commented Jan 20, 2025

(Stumbled on this while working on Open-EO/openeo-python-client#690)

def resample_spatial(args: ProcessArgs, env: EvalEnv) -> DriverDataCube:
cube: DriverDataCube = args.get_required("data", expected_type=DriverDataCube)
resolution = args.get_optional("resolution", 0)
projection = args.get_optional("projection", None)
method = args.get_optional("method", "near")
align = args.get_optional("align", "lower-left")
return cube.resample_spatial(resolution=resolution, projection=projection, method=method, align=align)

Here we use default "lower-left" for align parameter

official resample_spatial spec specifies default "upper-left" for align

@soxofaan
Copy link
Member Author

turns out the align value is not used yet (e.g see https://github.com/Open-EO/openeo-geopyspark-driver/blob/69b1b46b097f1c208652d8c650485091bbd96c2d/openeogeotrellis/geopysparkdatacube.py#L1297) so we can just update the default without much worries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant