Fixes for using PostgreSQL (#2467)

Created enum types should also be dropped on downgrade. Dropping tables must be committed to become visible.
Open-MSS · Aug 22, 2024 · 4344e00 · 4344e00
1 parent da36488
commit 4344e00
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/mslib/mscolab/migrations/versions/92eaba86a92e_to_version_8_3_5_initial_migration.py b/mslib/mscolab/migrations/versions/92eaba86a92e_to_version_8_3_5_initial_migration.py
@@ -81,7 +81,9 @@ def upgrade():
 def downgrade():
     # ### commands auto generated by Alembic - please adjust! ###
     op.drop_table('permissions')
+    sa.Enum(name='access_level').drop(op.get_bind(), checkfirst=False)
     op.drop_table('messages')
+    sa.Enum(name='messagetype').drop(op.get_bind(), checkfirst=False)
     op.drop_table('changes')
     op.drop_table('users')
     op.drop_table('operations')

diff --git a/tests/_test_mscolab/test_migrations.py b/tests/_test_mscolab/test_migrations.py
@@ -102,6 +102,7 @@ def test_upgrade_from(revision, iterations, mscolab_app, tmp_path):
         with mscolab_app.app_context():
             db.drop_all()
             db.session.execute(sqlalchemy.text("DROP TABLE alembic_version"))
+            db.session.commit()
             inspector = sqlalchemy.inspect(db.engine)
             existing_tables = inspector.get_table_names()
             assert existing_tables == []