Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify creation of plotting classes by better preparing necessary data #1011

Closed
joernu76 opened this issue May 31, 2021 · 0 comments · Fixed by #1012
Closed

Simplify creation of plotting classes by better preparing necessary data #1011

joernu76 opened this issue May 31, 2021 · 0 comments · Fixed by #1012
Assignees
@joernu76
Labels
enhancement New feature or request mswms
Milestone
5.0.0

Comments

@joernu76
Copy link
Member

joernu76 commented May 31, 2021 •
edited
Loading

Currently, the 2-D air_pressure field needs to be manually computed, which should be automated.

Also lon/lat 2-D fields have to always be computed in the same fashion using meshgrid and basemap projection.

Vertical plots require a similar thing to get the 2-D field for the horizontal axis.

All these things should be prepared before calling the _plot_style function.
@joernu76 joernu76 added this to the 4.1.0 milestone May 31, 2021
@joernu76 joernu76 self-assigned this May 31, 2021
@ReimarBauer ReimarBauer added the enhancement New feature or request label May 31, 2021
joernu76 added a commit that referenced this issue May 31, 2021
@joernu76
Simplify plotting by better preparing things.
dddf66b 
* Added proper 2-D lon/lat coordinates for horizontal plots
* Added propler 2-D lat coordinate for vertical plots
* Provide air_pressure field for vertical plots for pressure axis data

Fix #1011
@joernu76 joernu76 mentioned this issue May 31, 2021
Merged
@joernu76 joernu76 changed the title Automatically provide an air_pressure field for "pl" VS plots Simplify creation of plotting classes by better preparing necessary data May 31, 2021
joernu76 added a commit that referenced this issue May 31, 2021
@joernu76
Simplify plotting by better preparing things.
e39cbcb 
* Added proper 2-D lon/lat coordinates for horizontal plots
* Added propler 2-D lat coordinate for vertical plots
* Provide air_pressure field for vertical plots for pressure axis data

Fix #1011
joernu76 added a commit that referenced this issue May 31, 2021
@joernu76
Simplify plotting by better preparing things.
8855c85 
* Added proper 2-D lon/lat coordinates for horizontal plots
* Added propler 2-D lat coordinate for vertical plots
* Provide air_pressure field for vertical plots for pressure axis data

Fix #1011
joernu76 added a commit that referenced this issue May 31, 2021
@joernu76
Simplify plotting by better preparing things.
ac74efc 
* Added proper 2-D lon/lat coordinates for horizontal plots
* Added propler 2-D lat coordinate for vertical plots
* Provide air_pressure field for vertical plots for pressure axis data

Fix #1011
joernu76 added a commit that referenced this issue May 31, 2021
@joernu76
Simplify plotting by better preparing things.
6ddafaa 
* Added proper 2-D lon/lat coordinates for horizontal plots
* Added propler 2-D lat coordinate for vertical plots
* Provide air_pressure field for vertical plots for pressure axis data

Fix #1011
joernu76 added a commit that referenced this issue May 31, 2021
@joernu76
Simplify plotting by better preparing things.
182c695 
* Added proper 2-D lon/lat coordinates for horizontal plots
* Added propler 2-D lat coordinate for vertical plots
* Provide air_pressure field for vertical plots for pressure axis data

Fix #1011
ReimarBauer added a commit that referenced this issue Jun 2, 2021
@joernu76 @ReimarBauer
Simplify plotting by better preparing things. (#1012)
97d88f6 
* Added proper 2-D lon/lat coordinates for horizontal plots
* Added propler 2-D lat coordinate for vertical plots
* Provide air_pressure field for vertical plots for pressure axis data

Fix #1011

Co-authored-by: ReimarBauer <rb.proj@gmail.com>
Marilyth pushed a commit to Marilyth/MSS that referenced this issue Jun 17, 2021
@joernu76 @ReimarBauer @Marilyth
Simplify plotting by better preparing things. (Open-MSS#1012)
bcb413e 
* Added proper 2-D lon/lat coordinates for horizontal plots
* Added propler 2-D lat coordinate for vertical plots
* Provide air_pressure field for vertical plots for pressure axis data

Fix Open-MSS#1011

Co-authored-by: ReimarBauer <rb.proj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joernu76 joernu76

Labels
enhancement New feature or request mswms
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Simplify plotting classes by preparing necessary information in base classes Open-MSS/MSS
2 participants
@ReimarBauer @joernu76