Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review tests #1138

Open
ReimarBauer opened this issue Aug 6, 2021 · 5 comments · Fixed by #1139
Open

review tests #1138

ReimarBauer opened this issue Aug 6, 2021 · 5 comments · Fixed by #1139
Assignees
@ReimarBauer @matrss
Labels
enhancement New feature or request
Milestone
10.0.0

Comments

@ReimarBauer
Copy link
Member

ReimarBauer commented Aug 6, 2021 •
edited
Loading

We recognized some tests still depend on others. order one by one.

In a first step these get skipped with a refactoring remark.

The next step is to refactor them.
@ReimarBauer ReimarBauer self-assigned this Aug 6, 2021
@ReimarBauer ReimarBauer added the enhancement New feature or request label Aug 6, 2021
@ReimarBauer ReimarBauer added this to the 5.1.0 milestone Aug 6, 2021
@ReimarBauer
Copy link
Member Author

I'm looking on the test with pytest-reverse and do prepare a conda-forge package of that too

joernu76 pushed a commit that referenced this issue Aug 13, 2021
@ReimarBauer
reviewing tests, #1138 (#1139)
bbf1313 
* skipped test_version_name_delete

* tests skipped, because they can be biased

* ToDos added

* skipped because failing in reverse order

* test assert removed

* hanging tests skipped

* a few tests skipped which fails in (reverse) order

* skipped because: An unhandled message box popped up during your test!

* simplified tests

* removed dependency to server start

* improved tests for user object, refactored test_files

* refactored test_files_api

* Test_Init_Server refactored

* server tests partial refactored

* test_server completed

* fixed type bug in server and updated test_server

* cleanup duplicated tests

* reactored test_server

* refactored test_utils

* refactored test_chat_manager.py for test_client

* refactored to test_client

* test_file_manager refactored for test_client

* refactored test_files to test_client

* test_files_api refactored for test_client

* refactored test_seed for test_client

* refactored call of db.init_app

* used userdata

* removed duplications

* enabled skipped tests

* introduces reverse order on testing

* disabled a test, because of KeyError

* renamed the "json" parameter

* tests start with a resetted database
@ReimarBauer ReimarBauer linked a pull request Aug 13, 2021 that will close this issue
reviewing tests, #1138 #1139
Merged
@ReimarBauer
Copy link
Member Author

There are some more to do, please leave this issue open.

@joernu76 joernu76 modified the milestones: 5.1.0, 6.0.0 Aug 26, 2021
@ReimarBauer ReimarBauer modified the milestones: 6.0.0, 7.0.0 Sep 16, 2021
@ReimarBauer ReimarBauer modified the milestones: 7.0.0, 8.0.0 Jun 3, 2022
@ReimarBauer ReimarBauer modified the milestones: 8.0.0, 9.0.0 Mar 1, 2023
@ReimarBauer
Copy link
Member Author

@matrss I think you can later close this.

@matrss
Copy link
Collaborator

matrss commented Feb 15, 2024

15 skipped tests get re-enabled in #2165, but there are another 11 tests that are still skipped afterwards. Those are either incomplete, outdated, can not be run with other tests due to specific config requirements (basic auth) or break other tests in ways that I wasn't able to fix. So this issue isn't entirely solved yet.

@matrss
Copy link
Collaborator

matrss commented May 6, 2024

While there are remaining tests that should be re-visited I think a lot has already been done on develop and the rest is not as pressing as to block a major release, so I'll push this back to v10.

@matrss matrss modified the milestones: 9.0.0, 10.0.0 May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ReimarBauer ReimarBauer

@matrss matrss

Labels
enhancement New feature or request
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

reviewing tests, #1138 ReimarBauer/MSS
3 participants
@ReimarBauer @matrss @joernu76