Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kml overlay should show the selected color close to the filename #644

Closed
ReimarBauer opened this issue Jan 26, 2021 · 4 comments · Fixed by #709
Closed

kml overlay should show the selected color close to the filename #644

ReimarBauer opened this issue Jan 26, 2021 · 4 comments · Fixed by #709
Assignees
@risehr
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
3.0.0

Comments

@ReimarBauer
Copy link
Member

It is difficult with multiple kml files in a list to find the right one. A double click opens the navigation to updates,

kml_colorpicker

We want right off the filename a box with the color used and optional that it can be changed by a click
Same for the line style.

Something like:

kml

Sources:
@ReimarBauer ReimarBauer added enhancement New feature or request good first issue Good for newcomers labels Jan 26, 2021
@ReimarBauer ReimarBauer added this to the 2.1.0 milestone Jan 26, 2021
@ReimarBauer ReimarBauer changed the title kml should show the selected color close to the filename kml overlay should show the selected color close to the filename Jan 26, 2021
@risehr
Copy link
Contributor

risehr commented Feb 6, 2021

Hey @ReimarBauer Can I try this issue?

@ReimarBauer
Copy link
Member Author

@risehr you have it

the function is also decribed on
https://open-mss.github.io/help/

@SagarBapodara
Copy link

Hey, @ReimarBauer is the issue still open? I would like to give try it.

@ReimarBauer
Copy link
Member Author

@SagarBapodara @risehr is working on this.

@risehr risehr mentioned this issue Mar 7, 2021
Merged
@ReimarBauer ReimarBauer linked a pull request Mar 7, 2021 that will close this issue
Solved issue #644 #709
Merged
ReimarBauer added a commit that referenced this issue Mar 26, 2021
@risehr @ReimarBauer
Solved issue #644 (#709)
81a62a3 
* ui_kmloverlay_dockwidget.ui file changed for showing color and linewidth of individual kml files

* Changed the ui_kmloverlay_dockwidget.py added features of showing color and linewidth to this dockwidget (.py extension) file

* Added functionality and connected slots to show the respective color and respective linewidth of individual kml files in the listwwidget( added changes to kmloverlay_dockwidget.py)

* Modified 'remove_file(self)' function in kmloverlay_dockwidget.py ; added functionality for not showing color or linewidth when there are no kml files present in the listwidget

* Instant changes/reflection to the color label and linewidth label when the color and linewidth is changed. And also previous code's optimization

* Change color option added to main kmloverlay gui, editing of linewidth is direct in the main kmloverlay gui, display selected color of kml file right next to the file and the height of the colour block is in correspondence with the linewidth of that specific kml file

* Discarded obsolete color label display and linewidth label. The icons were made to appear directly upon startup of kmloverlaywidget. On clicking kml files it shows linewidth and you can edit from there directly.

* Optimized the code by setting flag to prevent the same icon being set twice because select_linewidth is called when item is clicked and also when valueChanged of spin box. Therefore, a flag is set to call select linewidth only when the value really changes.

* flake8 test run successfuly without any errors

* Improved functionality for setting color icons while adding files and tried the tests again

* Modified test_kmloverlay_dockwidget.py test file and removed brackets from if() in kmloverlay_dockwidget.py

* changes in test_wms_control/py for flake8 test to pass

* Added features for hiding of linewidth & color options until a file is selected. Made linewidth editor box faster which was slowing down significantly. Made color change much faster. Modified the tests also.

* Installed qt==5.9.7 and changed ui_kmloverlay_dockwidget.py and ui_kmloverlay_dockwidget.ui and removed the attribute setSteptype

* Made Change Color button transparent. Added the current color of the KML file to the QColorDialog selected color. Shortened range of linewidth from 0.1 to 10

Co-authored-by: ReimarBauer <rb.proj@gmail.com>
risehr added a commit to risehr/MSS that referenced this issue Mar 26, 2021
@risehr
Merge pull request #4 from Open-MSS/develop
c477856 
Solved issue Open-MSS#644 (Open-MSS#709)
@ReimarBauer ReimarBauer modified the milestones: 2.1.0, 3.0.0 Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@risehr risehr

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Solved issue #644 risehr/MSS
3 participants
@ReimarBauer @risehr @SagarBapodara